From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754140AbZEIRNW (ORCPT ); Sat, 9 May 2009 13:13:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752253AbZEIRNF (ORCPT ); Sat, 9 May 2009 13:13:05 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36506 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbZEIRND (ORCPT ); Sat, 9 May 2009 13:13:03 -0400 Date: Sat, 9 May 2009 19:12:53 +0200 From: Jiri Pirko To: Richard Genoud Cc: Jay Vosburgh , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] Remove duplicate slow protocol define in bond_3ad.h Message-ID: <20090509171250.GA3390@psychotron.englab.brq.redhat.com> References: <1241888356-7575-1-git-send-email-richard.genoud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1241888356-7575-1-git-send-email-richard.genoud@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sat, May 09, 2009 at 06:59:16PM CEST, richard.genoud@gmail.com wrote: >ETH_P_SLOW is already defined in include/linux/if_ether.h. >There's no need to define BOND_ETH_P_LACPDU in drivers/net/bonding/bond_3ad.h > >Signed-off-by: Richard Genoud >--- > drivers/net/bonding/bond_3ad.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/bonding/bond_3ad.h b/drivers/net/bonding/bond_3ad.h >index a306230..2c46a15 100644 >--- a/drivers/net/bonding/bond_3ad.h >+++ b/drivers/net/bonding/bond_3ad.h >@@ -26,10 +26,10 @@ > #include > #include > #include >+#include > > // General definitions >-#define BOND_ETH_P_LACPDU 0x8809 >-#define PKT_TYPE_LACPDU cpu_to_be16(BOND_ETH_P_LACPDU) >+#define PKT_TYPE_LACPDU cpu_to_be16(ETH_P_SLOW) > #define AD_TIMER_INTERVAL 100 /*msec*/ > > #define MULTICAST_LACPDU_ADDR {0x01, 0x80, 0xC2, 0x00, 0x00, 0x02} >-- >1.6.0.4 Looks good. Signed-off-by: Jiri Pirko > >-- >To unsubscribe from this list: send the line "unsubscribe netdev" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html