From: David Miller <davem@davemloft.net>
To: michael@ellerman.id.au
Cc: matthew@wil.cx, jbarnes@virtuousgeek.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix MSI-X with NIU cards
Date: Mon, 11 May 2009 16:40:17 -0700 (PDT) [thread overview]
Message-ID: <20090511.164017.116664605.davem@davemloft.net> (raw)
In-Reply-To: <1242052211.7011.4.camel@concordia>
From: Michael Ellerman <michael@ellerman.id.au>
Date: Tue, 12 May 2009 00:30:11 +1000
> On Sun, 2009-05-10 at 22:36 -0700, David Miller wrote:
>> From: Michael Ellerman <michael@ellerman.id.au>
>> Date: Mon, 11 May 2009 11:21:51 +1000
>>
>> > So I guess this device is just silently ignoring that write?
>>
>> No, it signals a fault on the PCI bus, which is how we noticed
>> this problem in the first place.
>
> But the patch doesn't change that? It just removes the readl AFAICS:
I'm on slow satellite internet here out in the ocean, so I wish
the author of this patch would help with your feedback :-/
> Or has msix_mask_irq() changed since 413f81eba?
You could ask GIT, and to answer your question, indeed it has.
Please don't stall this patch very much, as the bug it is fixing konks
out one of my primary test machines from even booting up.
next prev parent reply other threads:[~2009-05-11 23:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 13:13 Matthew Wilcox
2009-05-11 1:21 ` Michael Ellerman
2009-05-11 5:36 ` David Miller
2009-05-11 14:30 ` Michael Ellerman
2009-05-11 23:40 ` David Miller [this message]
2009-05-11 23:59 ` Jesse Barnes
2009-05-12 2:21 ` Michael Ellerman
2009-05-13 10:07 ` Matthew Wilcox
2009-05-13 4:06 ` Hidetoshi Seto
2009-05-13 4:40 ` Hidetoshi Seto
2009-05-13 4:49 ` Michael Ellerman
2009-05-13 4:10 ` [PATCH] PCI MSI: Yet another fix for " Hidetoshi Seto
2009-05-13 5:13 ` David Miller
2009-05-13 4:54 ` [PATCH] PCI MSI: Yet another fix for MSI-X with NIU cards, v2 Hidetoshi Seto
2009-05-13 5:06 ` Hidetoshi Seto
2009-05-13 6:31 ` Michael Ellerman
2009-05-13 18:43 ` Matthew Wilcox
2009-05-14 6:22 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511.164017.116664605.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®