From: Nick Piggin <npiggin@suse.de>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
mel@csn.ul.ie, a.p.zijlstra@chello.nl, cl@linux-foundation.org,
dave@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
Divy Le Ray <divy@chelsio.com>
Subject: Re: [patch -mmotm] mm: invoke oom killer for __GFP_NOFAIL
Date: Tue, 12 May 2009 15:05:46 +0200 [thread overview]
Message-ID: <20090512130546.GA15793@wotan.suse.de> (raw)
In-Reply-To: <20090512124201.GO4140@kernel.dk>
On Tue, May 12, 2009 at 02:42:02PM +0200, Jens Axboe wrote:
> On Mon, May 11 2009, Andrew Morton wrote:
> > On Sat, 9 May 2009 15:46:39 -0700 (PDT)
> > David Rientjes <rientjes@google.com> wrote:
> >
> > > The oom killer must be invoked regardless of the order if the allocation
> > > is __GFP_NOFAIL, otherwise it will loop forever when reclaim fails to
> > > free some memory.
> >
> > Sigh. We're supposed to be deleting __GFP_NOFAIL. I added it as a way
> > of easily finding lame error-handling-challenged callers which need to
> > be fixed up. So of course we went and added lots more callers.
> >
> > y:/usr/src/linux-2.6.30-rc5> grep -rl GFP_NOFAIL .
> > ./fs/bio-integrity.c
This is no good either, it seems to be in the bio submission path.
It needs a mempool or something.
It has a dead code "fallback" that returns an error, but I suspect that's
not really acceptable.
next prev parent reply other threads:[~2009-05-12 13:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 22:46 David Rientjes
2009-05-10 23:42 ` Rik van Riel
2009-05-11 7:29 ` Minchan Kim
2009-05-11 8:40 ` David Rientjes
2009-05-11 9:12 ` Minchan Kim
2009-05-11 11:21 ` Minchan Kim
2009-05-11 13:38 ` Mel Gorman
2009-05-11 14:00 ` Minchan Kim
2009-05-11 19:32 ` David Rientjes
2009-05-11 23:48 ` Minchan Kim
2009-05-11 21:32 ` Mel Gorman
2009-05-11 23:41 ` Minchan Kim
2009-05-11 10:40 ` Mel Gorman
2009-05-11 19:37 ` David Rientjes
2009-05-11 20:40 ` Andrew Morton
2009-05-12 12:42 ` Jens Axboe
2009-05-12 13:05 ` Nick Piggin [this message]
2009-05-12 16:37 ` Jens Axboe
2009-05-12 16:49 ` Nick Piggin
2009-05-12 17:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512130546.GA15793@wotan.suse.de \
--to=npiggin@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=divy@chelsio.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®