From: Arnd Bergmann <ARNDB@de.ibm.com>
To: jblunck@suse.de
Cc: Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [patch 1/2] spufs: make dentry reference count and locking symmetric
Date: Tue, 12 May 2009 16:03:49 +0200 [thread overview]
Message-ID: <200905121603.50251.ARNDB@de.ibm.com> (raw)
In-Reply-To: <20090505214433.946117208@suse.de>
On Tuesday 05 May 2009, jblunck@suse.de wrote:
> @@ -505,10 +505,7 @@ spufs_create_context(struct inode *inode
> out_aff_unlock:
> if (affinity)
> mutex_unlock(&gang->aff_mutex);
> -out_unlock:
> - mutex_unlock(&inode->i_mutex);
> out:
> - dput(dentry);
> return ret;
> }
>
There is a nasty deadlock problem with spu_forget(), which we
must call after unlocking i_mutex but before the final dput, IIRC.
The path down there is something like
spu_forget -> mmput -> exit_mmap -> remove_vma ->
fput -> dput -> dentry_iput -> iput -> iput_final ->
spufs_delete_inode -> destroy_spu_context.
Arnd <><
next prev parent reply other threads:[~2009-05-12 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 21:32 [patch 0/2] spufs: Minor cleanups jblunck
2009-05-05 21:32 ` [patch 1/2] spufs: make dentry reference count and locking symmetric jblunck
2009-05-12 14:03 ` Arnd Bergmann [this message]
2009-05-05 21:32 ` [patch 2/2] spufs: remove double check for non-negative dentry jblunck
2009-05-12 14:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905121603.50251.ARNDB@de.ibm.com \
--to=arndb@de.ibm.com \
--cc=jblunck@suse.de \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome