From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762444AbZENG4a (ORCPT ); Thu, 14 May 2009 02:56:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760947AbZENG4U (ORCPT ); Thu, 14 May 2009 02:56:20 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:44888 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760866AbZENG4T (ORCPT ); Thu, 14 May 2009 02:56:19 -0400 Date: Thu, 14 May 2009 08:56:11 +0200 From: Sascha Hauer To: Daniel Mack Cc: Vladimir Barinov , linux-kernel@vger.kernel.org, Linux MTD list Subject: Re: [PATCH] mtd: mxc_nand: fix built breakage Message-ID: <20090514065611.GU29278@pengutronix.de> References: <1242229410-11853-1-git-send-email-daniel@caiaq.de> <4A0AF0C7.5090104@embeddedalley.com> <20090513161154.GK32424@buzzloop.caiaq.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090513161154.GK32424@buzzloop.caiaq.de> X-Sent-From: Pengutronix Entwicklungszentrum Nord - Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Impressum: Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Peiner Strasse 6-8, 31137 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-5555 Inhaber: Dipl.-Ing. Robert Schwebel X-Message-Flag: See Message Headers for Impressum X-Uptime: 08:52:26 up 2 days, 21:16, 13 users, load average: 0.00, 0.01, 0.00 User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2009 at 06:11:54PM +0200, Daniel Mack wrote: > On Wed, May 13, 2009 at 08:09:43PM +0400, Vladimir Barinov wrote: > > Please find the patch that I've sent some time ago. This patch should > > fix the issue you described. > > http://lists.infradead.org/pipermail/linux-mtd/2009-April/025363.html > > > Ah, ok, thanks. > > Did anyone pick it up for mainline already? > Sascha, I didn't see that one in your tree either. It seems to be pure luck when the patches on the mtd list get picked up. Most of the time I do not even a reaction from the list or David. I wonder if someone will beat me up when I take the i.MX nand patches via my arm tree. Sascha > > Daniel > > > > Daniel Mack wrote: > >> The MXC NAND driver does not currently build with CONFIG_PM set. > >> > >> drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_suspend': > >> drivers/mtd/nand/mxc_nand.c:1021: error: 'nfc_clk' undeclared (first use in this function) > >> drivers/mtd/nand/mxc_nand.c:1021: error: (Each undeclared identifier is reported only once > >> drivers/mtd/nand/mxc_nand.c:1021: error: for each function it appears in.) > >> drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_resume': > >> drivers/mtd/nand/mxc_nand.c:1033: error: 'nfc_clk' undeclared (first use in this function) > >> make[3]: *** [drivers/mtd/nand/mxc_nand.o] Error 1 > >> make[2]: *** [drivers/mtd/nand] Error 2 > >> make[1]: *** [drivers/mtd] Error 2 > >> make: *** [drivers] Error 2 > >> > >> Signed-off-by: Daniel Mack > >> Cc: Sascha Hauer > >> Cc: Linux MTD list > >> --- > >> drivers/mtd/nand/mxc_nand.c | 8 ++++++-- > >> 1 files changed, 6 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c > >> index 21fd4f1..d352d2a 100644 > >> --- a/drivers/mtd/nand/mxc_nand.c > >> +++ b/drivers/mtd/nand/mxc_nand.c > >> @@ -1011,6 +1011,8 @@ static int __devexit mxcnd_remove(struct platform_device *pdev) > >> static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state) > >> { > >> struct mtd_info *info = platform_get_drvdata(pdev); > >> + struct nand_chip *nand_chip = info->priv; > >> + struct mxc_nand_host *host = nand_chip->priv; > >> int ret = 0; > >> DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND suspend\n"); > >> @@ -1018,7 +1020,7 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state) > >> ret = info->suspend(info); > >> /* Disable the NFC clock */ > >> - clk_disable(nfc_clk); /* FIXME */ > >> + clk_disable(host->clk); /* FIXME */ > >> return ret; > >> } > >> @@ -1026,11 +1028,13 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state) > >> static int mxcnd_resume(struct platform_device *pdev) > >> { > >> struct mtd_info *info = platform_get_drvdata(pdev); > >> + struct nand_chip *nand_chip = info->priv; > >> + struct mxc_nand_host *host = nand_chip->priv; > >> int ret = 0; > >> DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND resume\n"); > >> /* Enable the NFC clock */ > >> - clk_enable(nfc_clk); /* FIXME */ > >> + clk_enable(host->clk); /* FIXME */ > >> if (info) > >> info->resume(info); > >> > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |