From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757178AbZENUcM (ORCPT ); Thu, 14 May 2009 16:32:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756803AbZENUbg (ORCPT ); Thu, 14 May 2009 16:31:36 -0400 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:3571 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756983AbZENUbe (ORCPT ); Thu, 14 May 2009 16:31:34 -0400 Subject: [PATCH 1/2] ACPI: acpi_device_register() should call device_register() To: lenb@kernel.org From: Alex Chiang Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 14 May 2009 08:31:32 -0600 Message-ID: <20090514143132.18569.36441.stgit@bob.kio> In-Reply-To: <20090514142941.18569.75813.stgit@bob.kio> References: <20090514142941.18569.75813.stgit@bob.kio> User-Agent: StGit/0.14.3.347.g594a MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no apparent reason for acpi_device_register() to manually register a new device in two steps (initialize then add). Just call device_register() directly. Signed-off-by: Alex Chiang --- drivers/acpi/scan.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 8ff510b..b8f5c00 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -530,11 +530,10 @@ static int acpi_device_register(struct acpi_device *device, if (device->parent) device->dev.parent = &parent->dev; device->dev.bus = &acpi_bus_type; - device_initialize(&device->dev); device->dev.release = &acpi_device_release; - result = device_add(&device->dev); + result = device_register(&device->dev); if(result) { - dev_err(&device->dev, "Error adding device\n"); + dev_err(&device->dev, "Error registering device\n"); goto end; }