mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org,
	linux-security-module@vger.kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
	Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
	Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Paul Moore <paul.moore@hp.com>
Subject: [patch 18/51] netlabel: Add CIPSO {set, del}attr request_sock functions
Date: Thu, 14 May 2009 15:32:53 -0700	[thread overview]
Message-ID: <20090514223523.199696101@mini.kroah.org> (raw)
In-Reply-To: <20090514223755.GA27019@kroah.com>

[-- Attachment #1: netlabel-add-cipso-set-del-attr-request_sock-functions.patch --]
[-- Type: text/plain, Size: 6099 bytes --]

2.6.29-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Paul Moore <paul.moore@hp.com>

[NOTE: based on 389fb800ac8be2832efedd19978a2b8ced37eb61]

Add the cipso_v4_req_setattr() and cipso_v4_req_delattr() functions to set and
delete the CIPSO security attributes on a request_sock used during a incoming
connection request.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

 include/net/cipso_ipv4.h |   17 ++++++
 net/ipv4/cipso_ipv4.c    |  130 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 147 insertions(+)

--- a/include/net/cipso_ipv4.h
+++ b/include/net/cipso_ipv4.h
@@ -40,6 +40,7 @@
 #include <linux/net.h>
 #include <linux/skbuff.h>
 #include <net/netlabel.h>
+#include <net/request_sock.h>
 #include <asm/atomic.h>
 
 /* known doi values */
@@ -215,6 +216,10 @@ int cipso_v4_sock_setattr(struct sock *s
 			  const struct netlbl_lsm_secattr *secattr);
 void cipso_v4_sock_delattr(struct sock *sk);
 int cipso_v4_sock_getattr(struct sock *sk, struct netlbl_lsm_secattr *secattr);
+int cipso_v4_req_setattr(struct request_sock *req,
+			 const struct cipso_v4_doi *doi_def,
+			 const struct netlbl_lsm_secattr *secattr);
+void cipso_v4_req_delattr(struct request_sock *req);
 int cipso_v4_skbuff_setattr(struct sk_buff *skb,
 			    const struct cipso_v4_doi *doi_def,
 			    const struct netlbl_lsm_secattr *secattr);
@@ -247,6 +252,18 @@ static inline int cipso_v4_sock_getattr(
 	return -ENOSYS;
 }
 
+static inline int cipso_v4_req_setattr(struct request_sock *req,
+				       const struct cipso_v4_doi *doi_def,
+				       const struct netlbl_lsm_secattr *secattr)
+{
+	return -ENOSYS;
+}
+
+static inline void cipso_v4_req_delattr(struct request_sock *req)
+{
+	return;
+}
+
 static inline int cipso_v4_skbuff_setattr(struct sk_buff *skb,
 				      const struct cipso_v4_doi *doi_def,
 				      const struct netlbl_lsm_secattr *secattr)
--- a/net/ipv4/cipso_ipv4.c
+++ b/net/ipv4/cipso_ipv4.c
@@ -1942,6 +1942,72 @@ socket_setattr_failure:
 }
 
 /**
+ * cipso_v4_req_setattr - Add a CIPSO option to a connection request socket
+ * @req: the connection request socket
+ * @doi_def: the CIPSO DOI to use
+ * @secattr: the specific security attributes of the socket
+ *
+ * Description:
+ * Set the CIPSO option on the given socket using the DOI definition and
+ * security attributes passed to the function.  Returns zero on success and
+ * negative values on failure.
+ *
+ */
+int cipso_v4_req_setattr(struct request_sock *req,
+			 const struct cipso_v4_doi *doi_def,
+			 const struct netlbl_lsm_secattr *secattr)
+{
+	int ret_val = -EPERM;
+	unsigned char *buf = NULL;
+	u32 buf_len;
+	u32 opt_len;
+	struct ip_options *opt = NULL;
+	struct inet_request_sock *req_inet;
+
+	/* We allocate the maximum CIPSO option size here so we are probably
+	 * being a little wasteful, but it makes our life _much_ easier later
+	 * on and after all we are only talking about 40 bytes. */
+	buf_len = CIPSO_V4_OPT_LEN_MAX;
+	buf = kmalloc(buf_len, GFP_ATOMIC);
+	if (buf == NULL) {
+		ret_val = -ENOMEM;
+		goto req_setattr_failure;
+	}
+
+	ret_val = cipso_v4_genopt(buf, buf_len, doi_def, secattr);
+	if (ret_val < 0)
+		goto req_setattr_failure;
+	buf_len = ret_val;
+
+	/* We can't use ip_options_get() directly because it makes a call to
+	 * ip_options_get_alloc() which allocates memory with GFP_KERNEL and
+	 * we won't always have CAP_NET_RAW even though we _always_ want to
+	 * set the IPOPT_CIPSO option. */
+	opt_len = (buf_len + 3) & ~3;
+	opt = kzalloc(sizeof(*opt) + opt_len, GFP_ATOMIC);
+	if (opt == NULL) {
+		ret_val = -ENOMEM;
+		goto req_setattr_failure;
+	}
+	memcpy(opt->__data, buf, buf_len);
+	opt->optlen = opt_len;
+	opt->cipso = sizeof(struct iphdr);
+	kfree(buf);
+	buf = NULL;
+
+	req_inet = inet_rsk(req);
+	opt = xchg(&req_inet->opt, opt);
+	kfree(opt);
+
+	return 0;
+
+req_setattr_failure:
+	kfree(buf);
+	kfree(opt);
+	return ret_val;
+}
+
+/**
  * cipso_v4_sock_delattr - Delete the CIPSO option from a socket
  * @sk: the socket
  *
@@ -2016,6 +2082,70 @@ void cipso_v4_sock_delattr(struct sock *
 }
 
 /**
+ * cipso_v4_req_delattr - Delete the CIPSO option from a request socket
+ * @reg: the request socket
+ *
+ * Description:
+ * Removes the CIPSO option from a request socket, if present.
+ *
+ */
+void cipso_v4_req_delattr(struct request_sock *req)
+{
+	struct ip_options *opt;
+	struct inet_request_sock *req_inet;
+
+	req_inet = inet_rsk(req);
+	opt = req_inet->opt;
+	if (opt == NULL || opt->cipso == 0)
+		return;
+
+	if (opt->srr || opt->rr || opt->ts || opt->router_alert) {
+		u8 cipso_len;
+		u8 cipso_off;
+		unsigned char *cipso_ptr;
+		int iter;
+		int optlen_new;
+
+		cipso_off = opt->cipso - sizeof(struct iphdr);
+		cipso_ptr = &opt->__data[cipso_off];
+		cipso_len = cipso_ptr[1];
+
+		if (opt->srr > opt->cipso)
+			opt->srr -= cipso_len;
+		if (opt->rr > opt->cipso)
+			opt->rr -= cipso_len;
+		if (opt->ts > opt->cipso)
+			opt->ts -= cipso_len;
+		if (opt->router_alert > opt->cipso)
+			opt->router_alert -= cipso_len;
+		opt->cipso = 0;
+
+		memmove(cipso_ptr, cipso_ptr + cipso_len,
+			opt->optlen - cipso_off - cipso_len);
+
+		/* determining the new total option length is tricky because of
+		 * the padding necessary, the only thing i can think to do at
+		 * this point is walk the options one-by-one, skipping the
+		 * padding at the end to determine the actual option size and
+		 * from there we can determine the new total option length */
+		iter = 0;
+		optlen_new = 0;
+		while (iter < opt->optlen)
+			if (opt->__data[iter] != IPOPT_NOP) {
+				iter += opt->__data[iter + 1];
+				optlen_new = iter;
+			} else
+				iter++;
+		opt->optlen = (optlen_new + 3) & ~3;
+	} else {
+		/* only the cipso option was present on the socket so we can
+		 * remove the entire option struct */
+		req_inet->opt = NULL;
+		kfree(opt);
+	}
+}
+
+/**
  * cipso_v4_getattr - Helper function for the cipso_v4_*_getattr functions
  * @cipso: the CIPSO v4 option
  * @secattr: the security attributes



  parent reply	other threads:[~2009-05-14 22:48 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090514223235.348540705@mini.kroah.org>
2009-05-14 22:37 ` [patch 00/51] 2.6.29-stable review Greg KH
2009-05-14 22:32   ` [patch 01/51] fiemap: fix problem with setting FIEMAP_EXTENT_LAST Greg KH
2009-05-14 22:32   ` [patch 02/51] md: remove ability to explicit set an inactive array to clean Greg KH
2009-05-14 22:32   ` [patch 03/51] md: fix some (more) errors with bitmaps on devices larger than 2TB Greg KH
2009-05-14 22:32   ` [patch 04/51] md/raid10: dont clear bitmap during recovery if array will still be degraded Greg KH
2009-05-14 22:32   ` [patch 05/51] md: fix loading of out-of-date bitmap Greg KH
2009-05-14 22:32   ` [patch 06/51] usb-serial: ftdi_sio: fix reference counting of ftdi_private Greg KH
2009-05-18 12:46     ` David Woodhouse
2009-05-18 23:33       ` [stable] " Greg KH
2009-05-14 22:32   ` [patch 07/51] USB: Gadget: fix UTF conversion in the usbstring library Greg KH
2009-05-14 22:32   ` [patch 08/51] ALSA: hda - Fix line-in on Mac Mini Core2 Duo Greg KH
2009-05-14 22:32   ` [patch 09/51] ASoC: Fix errors in WM8990 Greg KH
2009-05-14 22:32   ` [patch 10/51] e1000: fix virtualization bug Greg KH
2009-05-14 22:32   ` [patch 11/51] hwmon: (w83781d) Fix W83782D support (NULL pointer dereference) Greg KH
2009-05-14 22:32   ` [patch 12/51] Fix for enabling branch profiling makes sparse unusable Greg KH
2009-05-14 22:32   ` [patch 13/51] i2c-algo-bit: Fix timeout test Greg KH
2009-05-14 22:32   ` [patch 14/51] i2c-algo-pca: Let PCA9564 recover from unacked data byte (state 0x30) Greg KH
2009-05-14 22:32   ` [patch 15/51] dup2: Fix return value with oldfd == newfd and invalid fd Greg KH
2009-05-14 22:32   ` [patch 16/51] ne2k-pci: Do not register device until initialized Greg KH
2009-05-14 22:32   ` [patch 17/51] lsm: Relocate the IPv4 security_inet_conn_request() hooks Greg KH
2009-05-14 22:32   ` Greg KH [this message]
2009-05-14 22:32   ` [patch 19/51] netlabel: Add new NetLabel KAPI interfaces for request_sock security attributes Greg KH
2009-05-14 22:32   ` [patch 20/51] selinux: Add new NetLabel glue code to handle labeling of connection requests Greg KH
2009-05-14 22:32   ` [patch 21/51] selinux: Set the proper NetLabel security attributes for " Greg KH
2009-05-14 22:32   ` [patch 22/51] selinux: Remove dead code labeled networking code Greg KH
2009-05-14 22:32   ` [patch 23/51] smack: Set the proper NetLabel security attributes for connection requests Greg KH
2009-05-14 22:32   ` [patch 24/51] cifs: Fix buffer size for tcon->nativeFileSystem field Greg KH
2009-05-14 22:33   ` [patch 25/51] cifs: Increase size of tmp_buf in cifs_readdir to avoid potential overflows Greg KH
2009-05-14 22:33   ` [patch 26/51] cifs: Fix incorrect destination buffer size in cifs_strncpy_to_host Greg KH
2009-05-14 22:33   ` [patch 27/51] cifs: Fix buffer size in cifs_convertUCSpath Greg KH
2009-05-14 22:33   ` [patch 28/51] cifs: Fix unicode string area word alignment in session setup Greg KH
2009-05-14 22:33   ` [patch 29/51] mac80211: pid, fix memory corruption Greg KH
2009-05-15  6:23     ` Jiri Slaby
2009-05-15 14:49       ` Greg KH
2009-05-15 15:09         ` Jiri Slaby
2009-05-18 23:33           ` [stable] " Greg KH
2009-05-15 21:49         ` Jiri Slaby
2009-06-09  8:18           ` [stable] " Greg KH
2009-05-14 22:33   ` [patch 30/51] mm: page_mkwrite change prototype to match fault Greg KH
2009-05-14 22:33   ` [patch 31/51] fs: fix page_mkwrite error cases in core code and btrfs Greg KH
2009-05-14 22:33   ` [patch 32/51] mm: close page_mkwrite races Greg KH
2009-05-14 22:33   ` [patch 33/51] GFS2: Fix page_mkwrite() return code Greg KH
2009-05-14 22:33   ` [patch 34/51] NFS: Fix the return value in nfs_page_mkwrite() Greg KH
2009-05-14 22:33   ` [patch 35/51] NFS: Close page_mkwrite() races Greg KH
2009-05-14 22:33   ` [patch 36/51] CIFS: Fix endian conversion of vcnum field Greg KH
2009-05-14 22:33   ` [patch 37/51] epoll: fix size check in epoll_create() Greg KH
2009-05-14 22:33   ` [patch 38/51] nfsd4: check for negative dentry before use in nfsv4 readdir Greg KH
2009-05-14 22:33   ` [patch 39/51] NFS: Fix the notifications when renaming onto an existing file Greg KH
2009-05-14 22:33   ` [patch 40/51] lockd: fix list corruption on lockd restart Greg KH
2009-05-14 22:33   ` [patch 41/51] dmatest: fix max channels handling Greg KH
2009-05-14 22:33   ` [patch 42/51] HID: add NOGET quirk for devices from CH Products Greg KH
2009-05-14 22:33   ` [patch 43/51] KVM: SVM: Remove port 80 passthrough Greg KH
2009-05-14 22:33   ` [patch 44/51] KVM: Make EFER reads safe when EFER does not exist Greg KH
2009-05-14 22:33   ` [patch 45/51] fuse: destroy bdi on error Greg KH
2009-05-14 22:33   ` [patch 46/51] splice: split up __splice_from_pipe() Greg KH
2009-05-14 22:33   ` [patch 47/51] splice: remove i_mutex locking in splice_from_pipe() Greg KH
2009-05-14 22:33   ` [patch 48/51] splice: fix i_mutex locking in generic_splice_write() Greg KH
2009-05-14 22:33   ` [patch 49/51] ocfs2: fix i_mutex locking in ocfs2_splice_to_file() Greg KH
2009-05-14 22:33   ` [patch 50/51] ehea: fix invalid pointer access Greg KH
2009-05-14 22:33   ` [patch 51/51] powerpc/5200: Dont specify IRQF_SHARED in PSC UART driver Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514223523.199696101@mini.kroah.org \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=eteo@redhat.com \
    --cc=jake@lwn.net \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=paul.moore@hp.com \
    --cc=rbranco@la.checkpoint.com \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®