From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758919AbZEOAv3 (ORCPT ); Thu, 14 May 2009 20:51:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753725AbZEOAvT (ORCPT ); Thu, 14 May 2009 20:51:19 -0400 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:55484 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbZEOAvT (ORCPT ); Thu, 14 May 2009 20:51:19 -0400 Date: Fri, 15 May 2009 09:38:53 +0900 From: Daisuke Nishimura To: KAMEZAWA Hiroyuki Cc: nishimura@mxp.nes.nec.co.jp, balbir@linux.vnet.ibm.com, "linux-mm@kvack.org" , "akpm@linux-foundation.org" , mingo@elte.hu, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/3] fix stale swap cache account leak in memcg v7 Message-Id: <20090515093853.e97fd120.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20090515084716.544930d9.kamezawa.hiroyu@jp.fujitsu.com> References: <20090512104401.28edc0a8.kamezawa.hiroyu@jp.fujitsu.com> <20090512095158.GB6351@balbir.in.ibm.com> <20090513093127.4dadac97.kamezawa.hiroyu@jp.fujitsu.com> <20090515084716.544930d9.kamezawa.hiroyu@jp.fujitsu.com> Organization: NEC Soft, Ltd. X-Mailer: Sylpheed 2.6.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 May 2009 08:47:16 +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 13 May 2009 09:31:27 +0900 > KAMEZAWA Hiroyuki wrote: > > > On Tue, 12 May 2009 15:21:58 +0530 > > Balbir Singh wrote: > > > > > > The patch set includes followng > > > > [1/3] add mem_cgroup_is_activated() function. which tell us memcg is _really_ used. > > > > [2/3] fix swap cache handling race by avoidng readahead. > > > > [3/3] fix swap cache handling race by check swapcount again. > > > > > > > > Result is good under my test. > > > > > > What was the result (performance data impact) of disabling swap > > > readahead? Otherwise, this looks the most reasonable set of patches > > > for this problem. > > > > > I'll measure some and report it in the next post. > > > I confirmed there are cases which swapin readahead works very well.... > > Nishimura-san, could you post a patch for fixing leak at writeback ? as [3/3] > I'd like to fix readahead case...with some large patch. > Sure. I'll rebase my patch onto [1-2/3] of your new patch and post it. > Hm, I didn't think this problem took 2 months to be fixed ;( > I didn't think so either. Thanks, Daisuke Nishimura.