mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] devpts: change the default value of devpts mode to 0620
Date: Fri, 15 May 2009 10:50:32 +0100	[thread overview]
Message-ID: <20090515105032.167eeb66@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4A0D2438.7020509@cn.fujitsu.com>

On Fri, 15 May 2009 16:13:44 +0800
Wei Yongjun <yjwei@cn.fujitsu.com> wrote:

> The value of devpts mode is usually set to 620 in file
> /etc/fstab like this:
> 
> $grep devpts /etc/fstab
> devpts /dev/pts devpts gid=5,mode=620 0 0
> 
> But the default mode value of devpts is 0600. Why not
> set it to 0620? This patch change it 0620.

NAK

The default is effectively ABI so you are changing it for people using
the 0600 default and doing nothing at all useful for those with 0620
defaults in their mount tab (which btw is distro dependant policy)

      reply	other threads:[~2009-05-15 10:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15  5:20 [PATCH] devpts: fix to set default values of mount options Wei Yongjun
2009-05-15  5:25 ` [PATCHv2] " Wei Yongjun
2009-05-15  8:13   ` [PATCH] devpts: change the default value of devpts mode to 0620 Wei Yongjun
2009-05-15  9:50     ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090515105032.167eeb66@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yjwei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®