From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759618AbZEORlW@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759618AbZEORlW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 May 2009 13:41:22 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756101AbZEORlF
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 15 May 2009 13:41:05 -0400
Received: from mx2.redhat.com ([66.187.237.31]:49531 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754985AbZEORlC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 May 2009 13:41:02 -0400
Date: Fri, 15 May 2009 11:31:14 -0600
From: Pete Zaitcev <zaitcev@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <jens.axboe@oracle.com>,
       James Bottomley <James.Bottomley@HansenPartnership.com>,
       Boaz Harrosh <bharrosh@panasas.com>,
       Linux Kernel <linux-kernel@vger.kernel.org>,
       linux-scsi <linux-scsi@vger.kernel.org>,
       IDE/ATA development list <linux-ide@vger.kernel.org>,
       Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
       Borislav Petkov <petkovbb@googlemail.com>
Subject: Re: [PATCH block#for-2.6.31 1/3] ub: use __blk_end_request_all()
Message-Id: <20090515113114.68ae93ae.zaitcev@redhat.com>
In-Reply-To: <4A0D86DB.9000203@kernel.org>
References: <4A0D86DB.9000203@kernel.org>
Organization: Red Hat, Inc.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 16 May 2009 00:14:35 +0900, Tejun Heo <tj@kernel.org> wrote:

> @@ -834,12 +829,7 @@ static void ub_end_rq(struct request *rq
>  		error = -EIO;
>  		rq->errors = scsi_status;
>  	}
> -	rqlen = blk_rq_bytes(rq);    /* Oddly enough, this is the residue. */
> -	if (__blk_end_request(rq, error, cmd_len)) {
> -		printk(KERN_WARNING DRV_NAME
> -		    ": __blk_end_request blew, %s-cmd total %u rqlen %ld\n",
> -		    blk_pc_request(rq)? "pc": "fs", cmd_len, rqlen);
> -	}
> +	__blk_end_request_all(rq, error);
>  }

I applaud this. We needed blk_end_this_mudafakin_request() for a long time.
Why two underscores?

-- Pete