mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86: update_mptable need pci_routeirq
Date: Fri, 15 May 2009 15:52:51 -0600	[thread overview]
Message-ID: <200905151552.53139.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <4A0DDAF0.7080005@kernel.org>

On Friday 15 May 2009 03:13:20 pm Yinghai Lu wrote:
> Bjorn Helgaas wrote:
> > On Friday 15 May 2009 01:51:56 pm Yinghai Lu wrote:
> >> to get all device irq routing and save them
> > 
> > This changelog isn't really enough for me to understand
> > what's going on.
> > 
> >> Index: linux-2.6/arch/x86/kernel/mpparse.c
> >> ===================================================================
> >> --- linux-2.6.orig/arch/x86/kernel/mpparse.c
> >> +++ linux-2.6/arch/x86/kernel/mpparse.c
> >> @@ -17,6 +17,7 @@
> >>  #include <linux/acpi.h>
> >>  #include <linux/module.h>
> >>  #include <linux/smp.h>
> >> +#include <linux/pci.h>
> >>  
> >>  #include <asm/mtrr.h>
> >>  #include <asm/mpspec.h>
> >> @@ -961,6 +962,7 @@ static int __initdata enable_update_mpta
> >>  static int __init update_mptable_setup(char *str)
> >>  {
> >>  	enable_update_mptable = 1;
> >> +	pci_routeirq = 1;
> > 
> > I hate to see new uses of pci_routeirq.  It'd be nice to remove it
> > completely someday.  But maybe it can't be helped.
> > 
> >>  	return 0;
> >>  }
> >>  early_param("update_mptable", update_mptable_setup);
> > 
> > "update_mptable" is apparently a boot option, but it's not mentioned
> > in Documentation/kernel-parameters.txt.  Is this some sort of debug
> > code or BIOS-writer's helper?  Same with "alloc_mptable".  Why do
> > we have this stuff?
> > 
> 
> 1. kexec path: after acpi kernel and use kexec to load kerenl with mptable support only or acpi=off
> 2. help to BIOS engineer to understand how to set mptable and irq routing setup by chipset.
>    esp system have several cards and there is bridge in those cards.

I was sort of hoping for a Documentation/kernel-parameters.txt patch.

Is (1) common enough to worry about?  What OSes don't have ACPI
support?  What advantage is there to using "acpi=off"?

(2) sounds like something that should be under a config option, if
it's in the mainline kernel at all.

Bjorn


  reply	other threads:[~2009-05-15 21:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15 19:51 Yinghai Lu
2009-05-15 19:53 ` [PATCH] x86/acpi: don't call mp_config_acpi_gsi if update_mptable is not used Yinghai Lu
2009-05-18  7:40   ` [tip:irq/numa] x86, irq: don't call mp_config_acpi_gsi() if update_mptable is not enabled tip-bot for Yinghai Lu
2009-05-15 21:07 ` [PATCH] x86: update_mptable need pci_routeirq Bjorn Helgaas
2009-05-15 21:13   ` Yinghai Lu
2009-05-15 21:52     ` Bjorn Helgaas [this message]
2009-05-15 22:03       ` Yinghai Lu
2009-05-15 22:08         ` Bjorn Helgaas
2009-05-16 10:25           ` Ingo Molnar
2009-05-16 16:44 ` [PATCH] x86: add X86_UPDATE_MPTABLE option Yinghai Lu
2009-05-18 15:41   ` Bjorn Helgaas
2009-05-18 17:39     ` Yinghai Lu
2009-05-18 17:59     ` [PATCH, v2] " Yinghai Lu
2009-05-18 20:58       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905151552.53139.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®