From: Kurt Garloff <garloff@suse.de>
To: Linux kernel list <linux-kernel@vger.kernel.org>
Cc: Norbert Eicker <N.Eicker@fz-juelich.de>,
Greg Kroah-Hartman <GregKH@suse.de>,
Alexey Starikovskiy <AStarikovskiy@suse.cz>,
Len Brown <LenB@kernel.org>
Subject: [PATCH 0/3]: Discard reserved PXM bits for SRAT v1
Date: Mon, 18 May 2009 11:33:52 +0200 [thread overview]
Message-ID: <20090518093352.GC15531@tpkurt2.garloff.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]
Hi,
ACPI specification says that the OS must disregard reserved bits.
The x86_64 SRAT parser does not discard the upper 24 bits of the
proximity_domain (pxm) in the acpi_srat_mem_affinity entries for
SRAT v1 tables. (v2 has 32 bits wide fields.)
This can lead to problems with poor BIOS implementations that failed
to set resreved bytes to zero. (The ACPI spec is a bit vague here
unfortunately.)
This was also inconsistent: On x86-64 (srat_64.c), the
_cpu_affinity does only use the low 8 bits of pxm, while the
full 32 bits of _mem_affinity are consumed.
In srat_32.c (x86), only 8bits are used (which is OK, a 32bit system
with >256 PXMs does not seem reasonable at all).
On ia64, the support of more than 8 bits was consistent between
mem and cpu affinity entries, however it dependent on "sn2" platform.
The patch series has the following goals:
* Make the kernel support consistently 8bits or 32bits for the
proximity domain
* Make this dependent on the SRAT version; v1 => 8bits, v2 => 32bits.
Overview over the patches:
- [1/3] Store the SRAT table version value in acpi_srat_revision
- [2/3] x86-64: Discard the upper 24 bits in mem_affinity if rev <= 1
and use upper 24bits in cpu_affinity if rev >= 2
- [3/3] ia64: Also use upper 8/24bits if rev >= 2 (but leave logic to
enable on sn2 as well -- I don't know if sn2 reports v1 or v2
SRAT) Also add two __init decls in ia64 pxm accessors.
Patch has been tested on x86-64 against an 2.6.27.x kernel.
(Patch is against current git.)
Thanks for James, Greg, Alexey, Norbert for comments, review and testing.
Please review and apply!
Greg, I believe this is a candidate for -stable.
--
Kurt Garloff, VP OPS Partner Engineering -- Novell Inc.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2009-05-18 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 9:33 Kurt Garloff [this message]
2009-05-18 9:46 ` [PATCH 1/3]: Store SRAT revision Kurt Garloff
2009-05-18 9:47 ` [PATCH 2/3]: x86-64: Handle SRAT v1 and v2 consistently Kurt Garloff
2009-05-18 20:04 ` Yinghai Lu
2009-05-18 9:49 ` [PATCH 3/3]: Consider SRAT rev on ia64 Kurt Garloff
2009-05-18 15:33 ` [PATCH 0/3]: Discard reserved PXM bits for SRAT v1 Greg KH
2009-05-19 9:01 ` xb
2009-06-22 14:05 ` Erik Jacobson
2009-07-14 16:55 ` [PATCH 0/3] Resend: " Kurt Garloff
2009-07-14 16:57 ` [PATCH 1/3] Resend: [PATCH 1/3]: Store SRAT revision Kurt Garloff
2009-07-14 16:58 ` [PATCH 2/3] Resend: x86-64: Handle SRAT v1 and v2 consistently Kurt Garloff
2009-07-17 22:10 ` Yinghai Lu
2009-07-14 16:59 ` [PATCH 3/3] Resend: Consider SRAT rev on ia64 Kurt Garloff
2009-08-13 13:38 ` [PATCH 0/3]: Discard reserved PXM bits for SRAT v1 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518093352.GC15531@tpkurt2.garloff.de \
--to=garloff@suse.de \
--cc=AStarikovskiy@suse.cz \
--cc=GregKH@suse.de \
--cc=LenB@kernel.org \
--cc=N.Eicker@fz-juelich.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome