From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756277AbZERLnp (ORCPT ); Mon, 18 May 2009 07:43:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754184AbZERLnf (ORCPT ); Mon, 18 May 2009 07:43:35 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:35346 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbZERLne (ORCPT ); Mon, 18 May 2009 07:43:34 -0400 Date: Mon, 18 May 2009 07:43:05 -0400 From: Christoph Hellwig To: Ferenc Wagner Cc: Ray Lee , Andrew Morton , Peter Staubach , Miklos Szeredi , xfs@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: mmap vs mtime in 2.6.26 and up Message-ID: <20090518114305.GA6303@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090515165054.GA11439@infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2009 at 12:50:54PM -0400, Christoph Hellwig wrote: > On Fri, May 15, 2009 at 06:40:29PM +0200, Ferenc Wagner wrote: > > Thanks for the analysis. Unfortunately I don't nearly know enough to > > work on this issue, but would like to track it as it affects our > > backup system. So, shouldn't #2645 be reopened again? > > Yes, definitively as the current "fix" is incorrected. I'll try to cook > up a correct version once I get some time. Doing this correctly in the framework of the current codee is unfortunately not so easy, as calling ->setattr requires taking i_mutex which we can't in the pagefaul path. To fix this properly we need to actually update the timestamps during msync and co as done by the patches from Miklos: http://lkml.org/lkml/2007/2/28/166 and Peter: http://lkml.org/lkml/2006/5/31/176 ----- End forwarded message -----