From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756141AbZETJ6W@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756141AbZETJ6W (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 May 2009 05:58:22 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754131AbZETJ6O
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 20 May 2009 05:58:14 -0400
Received: from mail-px0-f103.google.com ([209.85.216.103]:47912 "EHLO
	mail-px0-f103.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754070AbZETJ6O (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 May 2009 05:58:14 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer
         :mime-version:content-type:content-transfer-encoding;
        b=q9uK0+UjxTr8bay+lsWoax9WON1/BwX0GYn8O578E5sMnptZkS2w1FrxKUqDSz2Qrs
         jCE9n/rR4OR8DOCD9cS6xbuLTSs3ceIrcqIGbhGpQCVVQ7ioz5RAiUyixzBf6XA5tfov
         ja4Ozy2ORnuMvFbj/o/+hRPMu7VaFBBcbECHs=
Date: Wed, 20 May 2009 18:58:03 +0900
From: Minchan Kim <minchan.kim@gmail.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Minchan Kim <minchan.kim@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Rik van Riel <riel@redhat.com>, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/3] clean up setup_per_zone_pages_min
Message-Id: <20090520185803.e5b0698a.minchan.kim@barrios-desktop>
In-Reply-To: <20090520085416.GA27056@csn.ul.ie>
References: <20090520161853.1bfd415c.minchan.kim@barrios-desktop>
	<20090520085416.GA27056@csn.ul.ie>
X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; i486-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Mel. 

On Wed, 20 May 2009 09:54:16 +0100
Mel Gorman <mel@csn.ul.ie> wrote:

> On Wed, May 20, 2009 at 04:18:53PM +0900, Minchan Kim wrote:
> > 
> > Mel changed zone->pages_[high/low/min] with zone->watermark array.
> > So, setup_per_zone_pages_min also have to be changed.
> > 
> 
> Just to be clear, this is a function renaming to match the new zone
> field name, not something I missed. As the function changes min, low and
> max, a better name might have been setup_per_zone_watermarks but whether

At first, I thouht, too. But It's handle of min_free_kbytes.
Documentation said, it's to compute a watermark[WMARK_MIN]. 
I think many people already used that knob to contorl pages_min to keep the 
low pages. 

So, I determined function name is proper now. 
If setup_per_zone_watermark is better than it, we also have to change with 
documentation. 

> you go with that name or not, this is better than what is there so;
> 
> Acked-by: Mel Gorman <mel@csn.ul.ie>


-- 
Kinds Regards
Minchan Kim