From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756970AbZEVOWS (ORCPT ); Fri, 22 May 2009 10:22:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754348AbZEVOWJ (ORCPT ); Fri, 22 May 2009 10:22:09 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37677 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753848AbZEVOWI (ORCPT ); Fri, 22 May 2009 10:22:08 -0400 Date: Fri, 22 May 2009 16:15:31 +0200 From: Stanislaw Gruszka To: Thomas Gleixner Cc: "linux-kernel@vger.kernel.org" , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Andrew Morton Subject: Re: [PATCH resend4 1/3] itimers: merge ITIMER_VIRT and ITIMER_PROF common code Message-ID: <20090522161531.116526c2@dhcp-lab-109.englab.brq.redhat.com> In-Reply-To: References: <20090522154331.3e6f5ca3@dhcp-lab-109.englab.brq.redhat.com> Organization: RedHat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Fri, 22 May 2009 16:08:34 +0200 (CEST) Thomas Gleixner wrote: > On Fri, 22 May 2009, Stanislaw Gruszka wrote: > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -790,10 +790,10 @@ static void posix_cpu_timers_init_group(struct signal_struct *sig) > > thread_group_cputime_init(sig); > > > > /* Expiration times and increments. */ > > - sig->it_virt_expires = cputime_zero; > > - sig->it_virt_incr = cputime_zero; > > - sig->it_prof_expires = cputime_zero; > > - sig->it_prof_incr = cputime_zero; > > + sig->it[0].expires = cputime_zero; > > + sig->it[0].incr = cputime_zero; > > + sig->it[1].expires = cputime_zero; > > + sig->it[1].incr = cputime_zero; > > Nit, can we please use CPUCLOCK_PROF/VIRT instead of 0/1 ? I wanted to avoid including here. Cheers Stanislaw