From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbZEYJA5 (ORCPT ); Mon, 25 May 2009 05:00:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751335AbZEYJAo (ORCPT ); Mon, 25 May 2009 05:00:44 -0400 Received: from gir.skynet.ie ([193.1.99.77]:52241 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274AbZEYJAn (ORCPT ); Mon, 25 May 2009 05:00:43 -0400 Date: Mon, 25 May 2009 10:00:41 +0100 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , KOSAKI Motohiro , Rik van Riel , Johannes Weiner , Yasunori Goto Subject: Re: [PATCH 2/3] add inactive ratio calculation function of each zone V2 Message-ID: <20090525090041.GB12160@csn.ul.ie> References: <20090521092321.ee57585e.minchan.kim@barrios-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20090521092321.ee57585e.minchan.kim@barrios-desktop> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2009 at 09:23:21AM +0900, Minchan Kim wrote: > Changelog since V1 > o Change function name from calculate_zone_inactive_ratio to calculate_inactive_ratio > - by Mel Gorman advise > o Modify tab indent - by Mel Gorman advise > > This patch devide setup_per_zone_inactive_ratio with > per-zone inactive ratio calculaton. > > This patch is just for helping my next patch. > (reset wmark_min and inactive ratio of zone when hotplug happens) > > Signed-off-by: Minchan Kim > Reviewed-by: KOSAKI Motohiro Reviewed-by: Mel Gorman > CC: Rik van Riel > CC: Johannes Weiner > --- > include/linux/mm.h | 1 + > mm/page_alloc.c | 28 ++++++++++++++++------------ > 2 files changed, 17 insertions(+), 12 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 7ea4d1b..5d7a835 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1059,6 +1059,7 @@ extern void set_dma_reserve(unsigned long new_dma_reserve); > extern void memmap_init_zone(unsigned long, int, unsigned long, > unsigned long, enum memmap_context); > extern void setup_per_zone_wmarks(void); > +extern void calculate_zone_inactive_ratio(struct zone *zone); > extern void mem_init(void); > extern void __init mmap_init(void); > extern void show_mem(void); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b518ea7..f11cfbf 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4553,22 +4553,26 @@ void setup_per_zone_wmarks(void) > * 1TB 101 10GB > * 10TB 320 32GB > */ > -static void __init setup_per_zone_inactive_ratio(void) > +void calculate_zone_inactive_ratio(struct zone *zone) > { > - struct zone *zone; > + unsigned int gb, ratio; > > - for_each_zone(zone) { > - unsigned int gb, ratio; > + /* Zone size in gigabytes */ > + gb = zone->present_pages >> (30 - PAGE_SHIFT); > + if (gb) > + ratio = int_sqrt(10 * gb); > + else > + ratio = 1; > > - /* Zone size in gigabytes */ > - gb = zone->present_pages >> (30 - PAGE_SHIFT); > - if (gb) > - ratio = int_sqrt(10 * gb); > - else > - ratio = 1; > + zone->inactive_ratio = ratio; > +} > > - zone->inactive_ratio = ratio; > - } > +static void __init setup_per_zone_inactive_ratio(void) > +{ > + struct zone *zone; > + > + for_each_zone(zone) > + calculate_zone_inactive_ratio(zone); > } > > /* > -- > 1.5.4.3 > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab