mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ptrace: wait_task_zombie: s/->parent/->real_parent/
Date: Tue, 26 May 2009 13:23:36 -0700 (PDT)	[thread overview]
Message-ID: <20090526202336.E8B3AFC2BD@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Monday, 25 May 2009 22:21:45 +0200 <20090525202145.GA25243@redhat.com>

> Change wait_task_zombie() to use ->real_parent instead of ->parent.

Acked-by: Roland McGrath <roland@redhat.com>

> We could even use current afaics, but ->real_parent is more clean.

Indeed, though the caller might not be ->real_parent, it will always be
one that shares ->signal with ->real_parent.  But I agree that using
->real_parent is the clean way.  Incidentally, as readability cleanup it
would make a lot of sense to move that block into a subroutine.


Thanks,
Roland

      reply	other threads:[~2009-05-26 20:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-25 20:21 Oleg Nesterov
2009-05-26 20:23 ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090526202336.E8B3AFC2BD@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®