From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt_tracer
Date: Tue, 26 May 2009 19:11:31 -0700 (PDT) [thread overview]
Message-ID: <20090527021131.4778BFC36B@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Monday, 25 May 2009 23:59:03 +0200 <20090525215903.GA9113@redhat.com>
> But is the current code correct? If we are not traced any longer
> si_pid/si_uid are not necessary right either, we should calculate them
> before ptrace_stop(), no?
Yes, though nothing really cares about these values for such cases.
(It's really only there for dealing with debuggers that were written
before PTRACE_SETSIGINFO was invented.)
It's probably best now to clean this up so that this logic is
applied in the tracer causing the resumption rather than in the
tracee. i.e. do it in ptrace_resume() and ptrace_detach(). It's
only now with your exhaustive clean-up of ptrace that we will get
really confident that we are covering all the possible paths that
can change ->exit_code and then resume it. (I think those two are
it, but you should check my logic.)
Thanks,
Roland
next prev parent reply other threads:[~2009-05-27 2:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 0:00 Oleg Nesterov
2009-05-25 21:59 ` Oleg Nesterov
2009-05-25 22:39 ` [RFC PATCH 8/X] ptrace: introduce ptrace_tracer() helper Oleg Nesterov
2009-05-27 2:45 ` Roland McGrath
2009-05-27 21:45 ` Oleg Nesterov
2009-05-27 22:24 ` Roland McGrath
2009-05-27 2:11 ` Roland McGrath [this message]
2009-05-27 22:41 ` [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt_tracer Oleg Nesterov
2009-05-27 23:05 ` ptrace && task->exit_code Oleg Nesterov
2009-05-27 23:21 ` Roland McGrath
2009-05-29 19:06 ` Oleg Nesterov
2009-06-01 2:16 ` Roland McGrath
2009-05-27 23:07 ` [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt_tracer Roland McGrath
2009-05-27 23:59 ` Oleg Nesterov
2009-05-28 0:32 ` Roland McGrath
2009-05-28 2:54 ` Oleg Nesterov
2009-05-28 3:19 ` Roland McGrath
2009-05-28 3:35 ` Oleg Nesterov
2009-05-28 19:28 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527021131.4778BFC36B@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®