mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
	sameo@linux.intel.com, holtmann@linux.intel.com,
	yi.zhu@intel.com, linux-kernel@vger.kernel.org,
	linville@tuxdriver.com, greg@kroah.com
Subject: Re: [PATCH] firmware: Allocate firmware id dynamically
Date: Wed, 27 May 2009 11:57:48 +1000	[thread overview]
Message-ID: <20090527115748.9ff0bad1.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20090526132351.9805f1e8.akpm@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]

Hi all,

On Tue, 26 May 2009 13:23:51 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as
> > > some drivers rely on it.
> > 
> > I think the 6 files should be converted, and FIRMWARE_NAME_MAX
> > removed, otherwise people will keep copying that crap around.
> > 
> >   drivers/pcmcia/ds.c
> >   drivers/usb/atm/ueagle-atm.c
> >   drivers/net/wireless/libertas/if_usb.c
> >   drivers/net/wireless/libertas/if_spi.c
> >   drivers/media/dvb/dvb-usb/dvb-usb.h
> >   drivers/media/common/tuners/tuner-xc2028.c
> 
> Yep.

$ git grep -l -w FIRMWARE_NAME_MAX next-20090526 
next-20090526:drivers/base/firmware_class.c
next-20090526:drivers/media/common/tuners/tuner-xc2028.c
next-20090526:drivers/media/dvb/dvb-usb/dvb-usb.h
next-20090526:drivers/net/wireless/libertas/if_spi.c
next-20090526:drivers/net/wireless/libertas/if_usb.c
next-20090526:drivers/net/wireless/p54/p54usb.c
next-20090526:drivers/pcmcia/ds.c
next-20090526:drivers/usb/atm/ueagle-atm.c
next-20090526:include/linux/firmware.h
next-20090526:samples/firmware_class/firmware_sample_firmware_class.c

Its already started ...

/me looks forward to more breakage in -next :-(
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-05-27  1:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26 14:04 Samuel Ortiz
2009-05-26 14:11 ` Kay Sievers
2009-05-26 20:23   ` Andrew Morton
2009-05-27  1:57     ` Stephen Rothwell [this message]
2009-05-27  8:17       ` Samuel Ortiz
2009-05-27  8:30         ` Kay Sievers
2009-05-27 15:04           ` Greg KH
2009-05-27  9:16         ` John W. Linville
2009-05-27  9:53           ` Samuel Ortiz
2009-05-27  6:19   ` Marcel Holtmann
2009-05-26 14:51 ` [PATCH] libertas: adapt for dynamic firmware id allocation John W. Linville
2009-05-26 17:02   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090527115748.9ff0bad1.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=holtmann@linux.intel.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=sameo@linux.intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®