From: Pierre Ossman <pierre@ossman.eu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dsaxena@plexity.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MMC: Add 400ms to CAFE SD controller resume path
Date: Thu, 28 May 2009 10:48:23 +0200 [thread overview]
Message-ID: <20090528104823.0a551ecb@mjolnir.ossman.eu> (raw)
In-Reply-To: <20090528013629.0173522b.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Thu, 28 May 2009 01:36:29 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 22 May 2009 13:51:50 +0200 Pierre Ossman <pierre@ossman.eu> wrote:
>
> >
> > Reading through that report, I don't believe you properly worked around
> > the bug. You only avoid bug 1339, but that's only mildly related.
> >
> > What this workaround does is to make sure that MMC_UNSAFE_RESUME
> > actually works. But if you change cards during suspend, the VFS bug
> > should reappear and you'll corrupt the partition table.
>
> What do you think the VFS did wrong here?
>
Might be the block layer as well. Somehow requests associated with an
old block device end up on the queue of a new block device. I don't
see how this can happen given Linux' device model, but somehow it does.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-05-28 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 20:05 Deepak Saxena
2009-05-22 11:51 ` Pierre Ossman
2009-05-28 8:36 ` Andrew Morton
2009-05-28 8:48 ` Pierre Ossman [this message]
2009-06-04 23:33 ` Deepak Saxena
2009-06-13 10:34 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528104823.0a551ecb@mjolnir.ossman.eu \
--to=pierre@ossman.eu \
--cc=akpm@linux-foundation.org \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®