From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753077AbZE1Eah (ORCPT ); Thu, 28 May 2009 00:30:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751964AbZE1Ea3 (ORCPT ); Thu, 28 May 2009 00:30:29 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:51508 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbZE1Ea2 (ORCPT ); Thu, 28 May 2009 00:30:28 -0400 From: KOSAKI Motohiro To: Robin Holt Subject: Re: [PATCH v3] zone_reclaim is always 0 by default Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Andrew Morton , Rik van Riel , Christoph Lameter , "Zhang, Yanmin" , Wu Fengguang In-Reply-To: <20090527095006.GE29447@sgi.com> References: <20090527164549.68B4.A69D9226@jp.fujitsu.com> <20090527095006.GE29447@sgi.com> Message-Id: <20090528132800.F0F5.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 28 May 2009 13:30:25 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, May 27, 2009 at 05:06:18PM +0900, KOSAKI Motohiro wrote: > > your last patch is one of considerable thing. but it has one weakness. > > in general "ifdef x86" is wrong idea. almost minor architecture don't > > have sufficient tester. the difference against x86 often makes bug. > > Then, unnecessary difference is hated by much people. > > Let me start by saying I can barely understand this entire email. > I appreciate that english is a second language for you and you are > doing a service to the linux community with your contributions despite > the language barrier. I commend you for your efforts. I do ask that if > there was more information contained in your email than I am replying too, > please reword it so I may understand. > > IIRC, my last patch made it an arch header option to set zone_reclaim_mode > to any value it desired while leaving the default as 1. The only arch > that changed the default was x86 (both 32 and 64 bit). That seems the > least disruptive to existing users. > > > So, I think we have two selectable choice. > > > > 1. remove zone_reclaim default setting completely (this patch) > > 2. Only PowerPC and IA64 have default zone_reclaim_mode settings, > > other architecture always use zone_reclaim_mode=0. > > Looks like 2 is the inverse of my patch. That is fine as well. The only > reason I formed the patch with the default of 1 and override on x86 is > it was one less line of change and one less file. OK. I appreciate we reach good agreement. I'll try make patch (2) in this week end. Thanks.