From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
To: akpm@beardog.cca.cpqcorp.net, jens@beardog.cca.cpqcorp.net,
Andrew Patterson <andrew.patterson@hp.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
LKML-SCSI <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v6] cciss: add cciss driver sysfs entries
Date: Thu, 28 May 2009 15:24:59 -0500 [thread overview]
Message-ID: <20090528202459.GC4846@beardog.cca.cpqcorp.net> (raw)
In-Reply-To: <20090413164524.17977.99322.stgit@bluto.andrew>
On Mon, Apr 13, 2009 at 10:45:25AM -0600, Andrew Patterson wrote:
This is version six of my patch to add sysfs entries to the cciss driver.
Changelog:
Version 3
Got rid of /sys/class/cciss_* entries. Now only show vendor, model,
rev, and unique_id at /sys/bus/pci/devices/ccissX/cXdY. Where X is the
controller nubmer and Y is the logical drive number.
Fixed a double memcpy of the serial number.
Documented new sysfs entries in
Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
Fixed tabs in Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
Removed unneeded device_attribute release functions
Fixed pahole-reported holes.
Version 4
Moved cciss_sysfs.c into cciss.c
Added cciss_bus_type to logical drive so we get /sys/bus/cciss/device/ccissX.
Version 5
Added cciss_bus_type to hba so we get /sys/bus/cciss/device/cYdZ.
Version 6
Use "sizeof() + 1" instead of "*LEN + 2" for *_show() routines.
Added back in ABI docs.
The following patch adds sysfs entries for the cciss driver. It adds
vendor, model, rev, and unique_id under /sys/block/cciss!c#d#/device
needed for RedHat BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=484419
This patch is based off os linus's 2.6 tree (2.6.30-rc1).
.../ABI/testing/sysfs-bus-pci-devices-cciss | 33 ++
drivers/block/cciss.c | 267 ++++++++++++++++++++
drivers/block/cciss.h | 24 +-
3 files changed, 314 insertions(+), 10 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
--
Andrew Patterson
prev parent reply other threads:[~2009-05-28 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090413164524.17977.99322.stgit@bluto.andrew>
[not found] ` <20090413164530.17977.32550.stgit@bluto.andrew>
2009-05-28 20:21 ` Mike Miller (OS Dev)
2009-05-29 19:48 ` Andrew Morton
2009-05-29 21:32 ` Mike Miller (OS Dev)
2009-05-28 20:24 ` Mike Miller (OS Dev) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528202459.GC4846@beardog.cca.cpqcorp.net \
--to=mikem@beardog.cca.cpqcorp.net \
--cc=akpm@beardog.cca.cpqcorp.net \
--cc=andrew.patterson@hp.com \
--cc=jens@beardog.cca.cpqcorp.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®