From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
vvscore@gmail.com
Subject: Re: [PATCH] 8250: Fix oops from setserial
Date: Sat, 30 May 2009 11:46:32 +0100 [thread overview]
Message-ID: <20090530114632.7f101b9a@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090530014311.93577673.akpm@linux-foundation.org>
> Sure, huge numbers of drivers use the cast.
>
> But I've never seen past sinnings as being a reason to continue sinning.
> Doing new code the right way doesn't result in worse code, and reduces
> the chances of someone copying and pasting the wrong way.
As I said please read the rest of the driver. It would ridiculous to have
one dereference done differently to the rest in several thousand lines of
code.
It's not a new driver, it's simply pasting a line from one place to
another to update a field.
next prev parent reply other threads:[~2009-05-30 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 13:01 Alan Cox
2009-05-30 3:54 ` Andrew Morton
2009-05-30 8:25 ` Alan Cox
2009-05-30 8:43 ` Andrew Morton
2009-05-30 10:46 ` Alan Cox [this message]
2009-05-30 18:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090530114632.7f101b9a@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vvscore@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®