From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Michael Buesch <mb@bu3sch.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: parport_pc: Fix subscription bugs
Date: Mon, 1 Jun 2009 10:14:40 +0100 [thread overview]
Message-ID: <20090601101440.203c000a@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200906011100.34086.mb@bu3sch.de>
On Mon, 1 Jun 2009 11:00:33 +0200
Michael Buesch <mb@bu3sch.de> wrote:
> This patch fixes array subscription bugs in the parport_pc driver.
>
> drivers/parport/parport_pc.c: In function ‘parport_irq_probe’:
> drivers/parport/parport_pc.c:1589: warning: array subscript is above array bounds
> drivers/parport/parport_pc.c: In function ‘parport_pc_probe_port’:
> drivers/parport/parport_pc.c:1579: warning: array subscript is above array bounds
>
> The patch also fixes a few other array bugs, which the compiler was
> unable to find. Coding style violations are also fixed.
Which makes it very hard to see what you are actually changing and
whether it is a bug. It certainly looks like one but the changes muddled
in with a random subset of format fixes (even in the area patched only
some style is fixed) looks pretty clunky - surely a for() loop would be
far cleaner.
But yes agreed - its a bug, it wants fixing and style can be sorted later.
next prev parent reply other threads:[~2009-06-01 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 9:00 Michael Buesch
2009-06-01 9:14 ` Alan Cox [this message]
2009-06-01 9:27 ` Michael Buesch
2009-06-01 9:58 ` Alan Cox
2009-06-01 10:17 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601101440.203c000a@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®