From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jarod Wilson <jarod@redhat.com>
Cc: dri-devel@lists.sourceforge.net, xorg-devel@lists.x.org,
linux-kernel@vger.kernel.org, Florian Demmer <florian@demmer.org>,
eric@anholt.net
Subject: Re: [PATCH] drm: intel: add ignore lvds quirk info for AOpen Mini PC
Date: Mon, 1 Jun 2009 12:01:26 +0100 [thread overview]
Message-ID: <20090601120126.550b2d15@jbarnes-x200> (raw)
In-Reply-To: <200905271720.40776.jarod@redhat.com>
On Wed, 27 May 2009 17:20:39 -0400
Jarod Wilson <jarod@redhat.com> wrote:
> Fix a FIXME in the intel LVDS bring-up code, adding the appropriate
> blacklist entry for the AOpen Mini PC, courtesy of a dmidecode
> dump from Florian Demmer.
>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> CC: Florian Demmer <florian@demmer.org>
>
> ---
> drivers/gpu/drm/i915/intel_lvds.c | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c
> b/drivers/gpu/drm/i915/intel_lvds.c index 439a865..7ac00c3 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -424,8 +424,14 @@ static const struct dmi_system_id __initdata
> intel_no_lvds[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
> },
> },
> -
> - /* FIXME: add a check for the Aopen Mini PC */
> + {
> + .callback = intel_no_lvds_dmi_callback,
> + .ident = "AOpen Mini PC",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
> + },
> + },
>
> { } /* terminating entry */
> };
>
Looks fine to me, Eric? Patches to the i915 driver should generally go
to intel-gfx@lists.freedesktop.org so we don't miss them. Thanks.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
next prev parent reply other threads:[~2009-06-01 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 21:20 Jarod Wilson
2009-06-01 11:01 ` Jesse Barnes [this message]
2009-06-01 15:54 ` Jarod Wilson
2009-06-01 16:11 ` Joe Perches
2009-06-01 16:17 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601120126.550b2d15@jbarnes-x200 \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=eric@anholt.net \
--cc=florian@demmer.org \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xorg-devel@lists.x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®