From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
To: balbir@linux.vnet.ibm.com
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>,
"menage@google.com" <menage@google.com>,
KOSAKI Motohiro <m-kosaki@ceres.dti.ne.jp>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Subject: Re: [RFC] Low overhead patches for the memory cgroup controller (v2)
Date: Mon, 1 Jun 2009 14:01:02 +0900 [thread overview]
Message-ID: <20090601140102.c55bdf03.nishimura@mxp.nes.nec.co.jp> (raw)
In-Reply-To: <20090601132505.2fe9c870.nishimura@mxp.nes.nec.co.jp>
> > @@ -1114,9 +1125,24 @@ static void __mem_cgroup_commit_charge(struct mem_cgroup *mem,
> > css_put(&mem->css);
> > return;
> > }
> > +
> > pc->mem_cgroup = mem;
> > smp_wmb();
> > - pc->flags = pcg_default_flags[ctype];
> > + switch (ctype) {
> > + case MEM_CGROUP_CHARGE_TYPE_CACHE:
> > + case MEM_CGROUP_CHARGE_TYPE_SHMEM:
> > + SetPageCgroupCache(pc);
> > + SetPageCgroupUsed(pc);
> > + break;
> > + case MEM_CGROUP_CHARGE_TYPE_MAPPED:
> > + SetPageCgroupUsed(pc);
> > + break;
> > + default:
> > + break;
> > + }
> > +
> > + if (mem == root_mem_cgroup)
> > + SetPageCgroupRoot(pc);
> >
> > mem_cgroup_charge_statistics(mem, pc, true);
> >
> Shouldn't we set PCG_LOCK ?
> unlock_page_cgroup() will be called after this.
>
Ah, lock_page_cgroup() has already set it.
please ignore this comment.
Sorry for noise.
Daisuke Nishimura.
next prev parent reply other threads:[~2009-06-01 5:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 17:45 KAMEZAWA Hiroyuki
2009-05-15 18:16 ` Balbir Singh
2009-05-18 10:11 ` KAMEZAWA Hiroyuki
2009-05-18 10:45 ` Balbir Singh
2009-05-18 16:01 ` KAMEZAWA Hiroyuki
2009-05-19 13:18 ` Balbir Singh
2009-05-17 4:15 ` Balbir Singh
2009-06-01 4:25 ` Daisuke Nishimura
2009-06-01 5:01 ` Daisuke Nishimura [this message]
2009-06-01 5:49 ` Balbir Singh
-- strict thread matches above, loose matches on Subject: below --
2009-05-15 15:18 Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601140102.c55bdf03.nishimura@mxp.nes.nec.co.jp \
--to=nishimura@mxp.nes.nec.co.jp \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=m-kosaki@ceres.dti.ne.jp \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®