From: Frans Pop <elendil@planet.nl>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Brown, Len" <len.brown@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [SOLVED] Build failure caused by 'cpuidle: makes AMD C1E work in acpi_idle'
Date: Tue, 2 Jun 2009 04:49:30 +0200 [thread overview]
Message-ID: <200906020449.32339.elendil@planet.nl> (raw)
In-Reply-To: <20090602010150.GA21166@sli10-desk.sh.intel.com>
On Tuesday 02 June 2009, Shaohua Li wrote:
> On Tue, Jun 02, 2009 at 12:58:08AM +0800, Frans Pop wrote:
> > $ git describe master
> > v2.6.30-rc7-227-gd9244b5
> >
> > [...]
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c: In
> > function ???acpi_processor_power_verify???:
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c:617
> >: error: implicit declaration of function ???acpi_timer_check_state???
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c: In
> > function ???acpi_idle_enter_c1???:
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c:839
> >: error: implicit declaration of function
> > ???acpi_state_timer_broadcast??? make[7]: ***
> > [drivers/acpi/processor_idle.o] Error 1
> >
> > Reverting the following two commits fixed the error:
> > 87ad57ba cpuidle: makes AMD C1E work in acpi_idle
> > 7d60e8ab cpuidle: fix AMD C1E suspend hang
> >
> > (Second one probably was not needed, but done as it looked related.)
>
> Can't reproduce it here with your config, can you double check please?
Ah, I'm sorry. I see what went wrong here.
For some reason I had a patch from Len that renames those functions in my
local branch (ACPI: idle: rename lapic timer workaround routines).
Not sure when or why I picked up that patch. I've dropped it now.
Sorry for the noise and inconvenience.
Cheers,
FJP
prev parent reply other threads:[~2009-06-02 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 16:58 [Regression] " Frans Pop
2009-06-02 1:01 ` Shaohua Li
2009-06-02 2:49 ` Frans Pop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906020449.32339.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®