From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Frans Pop <elendil@planet.nl>,
linux-usb@vger.kernel.org, linux-pm@lists.linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@suse.de>
Subject: Re: [PATCH v2] usb: avoid PM error messages during resume if a device was disconnected
Date: Wed, 3 Jun 2009 10:08:52 +0200 [thread overview]
Message-ID: <200906031008.53326.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0906022056070.8257-100000@netrider.rowland.org>
On Wednesday 03 June 2009, Alan Stern wrote:
> On Wed, 3 Jun 2009, Rafael J. Wysocki wrote:
>
> > > + /* Avoid PM error messages for devices disconnected while suspended
> > > + * as we'll display regular disconnect messages just a bit later.
> > > + */
> > > + if (status == -ENODEV)
> > > + return 0;
> > > + return status;
> >
> > + return status == -ENODEV ? 0 : status;
> >
> > maybe?
> >
> > > }
> > >
> > > #endif /* CONFIG_PM */
>
> Personally, I would do:
>
> if (status == -ENODEV)
> status = 0;
> return status;
>
> It doesn't make any difference; they are all equally good.
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
OK
Am I supposed to take this patch directly or push it to Greg?
Rafael
prev parent reply other threads:[~2009-06-03 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 21:11 [PATCH] " Frans Pop
2009-03-23 21:30 ` Frans Pop
2009-03-23 21:44 ` Alan Stern
2009-03-23 22:25 ` Frans Pop
2009-03-24 14:11 ` Alan Stern
2009-06-02 21:26 ` Rafael J. Wysocki
2009-06-02 21:48 ` Alan Stern
2009-06-02 22:26 ` [PATCH v2] " Frans Pop
2009-06-02 22:53 ` Rafael J. Wysocki
2009-06-03 0:57 ` Alan Stern
2009-06-03 8:08 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906031008.53326.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=elendil@planet.nl \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome