mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH resend5 4/4] cputime: optimize jiffies_to_cputime(1)
Date: Wed, 3 Jun 2009 15:06:57 +0200	[thread overview]
Message-ID: <20090603150657.0a60a474@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0905291406370.3397@localhost.localdomain>

Hi.

> > This patch (with 3 previous) was compiled on x86, x86_64, ppc with
> > CONFIG_VIRT_CPU_ACCOUNTNG=n, ppc64 with CONFIG_VIRT_CPU_ACCOUNTING=y.
> > Run time testing was done only on x86.

I tested patches on ppc64 with CONFIG_VIRT_CPU_ACCOUNTING=y . Additionally I
measure impact of iffies_to_cputime(1) to cputime_one_jiffiy conversion on
check_cpu_itimer() calls with below code:

+       xstart = get_cycles();
+       barrier();
        check_cpu_itimer(tsk, &sig->it[CPUCLOCK_PROF], &prof_expires, ptime,
                         SIGPROF);
        check_cpu_itimer(tsk, &sig->it[CPUCLOCK_VIRT], &virt_expires, utime,
                         SIGVTALRM);
+       barrier();
+       xend = get_cycles();
+       check_cpu_itimer_cycles += xend - xstart;
+       check_cpu_itimer_n++;

Using cputime_one_jiffy was about 4% faster.

Cheers
Stanislaw

      reply	other threads:[~2009-06-03 13:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29 11:19 Stanislaw Gruszka
2009-05-29 12:09 ` Thomas Gleixner
2009-06-03 13:06   ` Stanislaw Gruszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090603150657.0a60a474@dhcp-lab-109.englab.brq.redhat.com \
    --to=sgruszka@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®