From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
wli@holomorphy.com, hch@infradead.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] vfs: Split generic_forget_inode() so that hugetlbfs does not have to copy it
Date: Wed, 3 Jun 2009 11:56:38 -0400 [thread overview]
Message-ID: <20090603155638.GA29914@infradead.org> (raw)
In-Reply-To: <1243959634-22067-1-git-send-email-jack@suse.cz>
On Tue, Jun 02, 2009 at 06:20:34PM +0200, Jan Kara wrote:
> Hugetlbfs needs to do special things instead of truncate_inode_pages().
> Currently, it copied generic_forget_inode() except for truncate_inode_pages()
> call which is asking for trouble (the code there isn't trivial). So create a
> separate function generic_detach_inode() which does all the list magic done in
> generic_forget_inode() and call it from hugetlbfs_forget_inode().
Looks good to me, but long term I'd just prefer to have
truncate_inode_pages do the right thing for huge pages..
> +/*
> + * Remove inode from inode lists, write it if it's dirty.
> + *
> + * Returns 1 if inode should be completely destroyed.
> + */
Please make this a kerneldoc comment. And mention that this is just
and internal helper that can go away any time.
next prev parent reply other threads:[~2009-06-03 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 16:20 Jan Kara
2009-06-03 15:56 ` Christoph Hellwig [this message]
2009-06-03 22:13 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603155638.GA29914@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®