Re: http://patchwork.kernel.org/patch/26483/ broke my system boot

[Sam Ravnborg <sam@ravnborg.org>]

On Fri, Jun 05, 2009 at 03:17:12AM -0400, Jon Masters wrote:
> On Thu, 2009-06-04 at 14:31 +0800, Balbir Singh wrote:
> > * Sam Ravnborg <sam@ravnborg.org> [2009-06-03 21:45:26]:
> > 
> > > On Wed, Jun 03, 2009 at 10:39:44PM +0800, Balbir Singh wrote:
> > > > After spending some time figuring out why my system failed to reboot,
> > > > checking config options, kernel version, modules installed. I figured
> > > > out that the patch in http://patchwork.kernel.org/patch/26483/ broke
> > > > the system boot on the latest mmotm. Reverting it helped my system
> > > > call depmod and hence boot.
> > > > 
> > > > The patch is really unhelpful, since the changelog is completely
> > > > empty. Sigh!
> > > 
> > > Yeah, sorry for not nak'ing it earlier. Has been busy.
> > > Andrew removed it from -mm and I notified the author about the
> > > problems with the patch (in private mail it seems - I just replied to what I had).
> > 
> > Cool! Thanks for the update. I'll get the latest mmotm and test as
> > well.
> 
> The general idea of using the cross-depmod is good though :) We have had
> a few people recently run their newer host depmod and wonder why their
> older embedded device can't read the new binary index files.

But then the patch would lok like this - no?

index 610d1c3..05c5744 100644
--- a/Makefile
+++ b/Makefile
@@ -325,7 +325,8 @@ OBJCOPY             = $(CROSS_COMPILE)objcopy
 OBJDUMP                = $(CROSS_COMPILE)objdump
 AWK            = awk
 GENKSYMS       = scripts/genksyms/genksyms
-DEPMOD         = /sbin/depmod
+DEPMOD         = $(if $(shell which $(CROSS_COMPILE)depmod),
+                       $(CROSS_COMPILE)depmod,/sbin/depmod)
 KALLSYMS       = scripts/kallsyms
 PERL           = perl
 CHECK          = sparse


	Sam