From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753205AbZFEVyH (ORCPT ); Fri, 5 Jun 2009 17:54:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752153AbZFEVxz (ORCPT ); Fri, 5 Jun 2009 17:53:55 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:59064 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbZFEVxy (ORCPT ); Fri, 5 Jun 2009 17:53:54 -0400 Date: Fri, 5 Jun 2009 23:56:11 +0200 From: Sam Ravnborg To: Cheng Renquan Cc: linux-kbuild@vger.kernel.org, Andrew Morton , linux-kernel@vger.kernel.org, crquan@gmail.com Subject: Re: [PATCH] Kbuild: remove extra ifdef/endif of top Makefile Message-ID: <20090605215611.GG29008@uranus.ravnborg.org> References: <1243324987-17840-1-git-send-email-crq@hera.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1243324987-17840-1-git-send-email-crq@hera.kernel.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2009 at 04:03:07PM +0800, Cheng Renquan wrote: > From: Cheng Renquan > > The GNU make's origin function know undefined variable well, > so the outer ifdef/endif is unneeded. > > I've checked the minimal requirements from Documentation/Changes > is GNU make 3.79.1, and that version of GNU make has support of > origin function already, so now it's safe to kill the outer > conditional checking, without upgrading the minimal requirements. Applied with V2 of your description, Sam