From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: mingo@elte.hu, vegard.nossum@gmail.com, john.dykstra1@gmail.com,
netdev@vger.kernel.org, penberg@cs.helsinki.fi,
linux-kernel@vger.kernel.org, jpirko@redhat.com
Subject: Re: [PATCH net-next-2.6] net: dev_addr_init() fix
Date: Tue, 09 Jun 2009 05:21:50 -0700 (PDT) [thread overview]
Message-ID: <20090609.052150.253563947.davem@davemloft.net> (raw)
In-Reply-To: <4A2D16E4.3030702@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 08 Jun 2009 15:49:24 +0200
> [PATCH net-next-2.6] net: dev_addr_init() fix
>
> commit f001fde5eadd915f4858d22ed70d7040f48767cf
> (net: introduce a list of device addresses dev_addr_list (v6))
> added one regression Vegard Nossum found in its testings.
>
> With kmemcheck help, Vegard found some uninitialized memory
> was read and reported to user, potentialy leaking kernel data.
> ( thread can be found on http://lkml.org/lkml/2009/5/30/177 )
>
> dev_addr_init() incorrectly uses sizeof() operator. We were
> initializing one byte instead of MAX_ADDR_LEN bytes.
>
> Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Jiri Pirko <jpirko@redhat.com>
Applied, thanks.
next prev parent reply other threads:[~2009-06-09 12:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 20:23 net: uninitialized loopback addr leaks to userspace Vegard Nossum
2009-06-07 21:03 ` John Dykstra
2009-06-08 10:00 ` Vegard Nossum
2009-06-08 10:44 ` [PATCH net-next-2.6] net: loopback device dev->addr_len fix Eric Dumazet
2009-06-08 12:13 ` [PATCH net-next-2.6] net: dev_addr_init() fix Eric Dumazet
2009-06-08 12:41 ` Jiri Pirko
2009-06-08 13:06 ` Ingo Molnar
2009-06-08 13:49 ` Eric Dumazet
2009-06-09 12:21 ` David Miller [this message]
2009-06-07 23:11 ` net: uninitialized loopback addr leaks to userspace Stephen Hemminger
2009-06-08 9:16 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609.052150.253563947.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.dykstra1@gmail.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®