mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Chuck Ebbert <cebbert@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: clear TS in irq_ts_save() when in an atomic section
Date: Tue, 9 Jun 2009 16:22:54 +0200	[thread overview]
Message-ID: <20090609142254.GC32703@elte.hu> (raw)
In-Reply-To: <20090609100512.7d191fd4@dhcp-100-2-144.bos.redhat.com>


* Chuck Ebbert <cebbert@redhat.com> wrote:

> -	if (!in_interrupt())
> +	if (!in_atomic() && !in_interrupt())
>  		return 0;

since in_interrupt() implies in_atomic() (upstream), why not just 
do:

	if (!in_atomic())
 		return 0;

?

	Ingo

  reply	other threads:[~2009-06-09 14:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 14:05 Chuck Ebbert
2009-06-09 14:22 ` Ingo Molnar [this message]
2009-06-09 14:40   ` [patch v2] " Chuck Ebbert
2009-06-09 14:53     ` [tip:x86/urgent] x86: Clear " tip-bot for Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090609142254.GC32703@elte.hu \
    --to=mingo@elte.hu \
    --cc=cebbert@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®