From: Wim Van Sebroeck <wim@iguana.be>
To: matthieu castet <castet.matthieu@free.fr>
Cc: Florian Fainelli <florian@openwrt.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
biblbroks@sezampro.rs
Subject: Re: add bcm47xx watchdog driver
Date: Wed, 10 Jun 2009 21:06:02 +0200 [thread overview]
Message-ID: <20090610190602.GL16090@infomag.iguana.be> (raw)
In-Reply-To: <4A2FFFDA.6010807@free.fr>
Hi Matthieu,
>> +
>> +#define WDT_DEFAULT_TIME 30 /* seconds */
>> +#define WDT_MAX_TIME 255 /* seconds */
> Why have changed this from 256 to 255 ?
Since you use a timer to control the real watchdog, the wdt_time function is arbitraty anyway.
Most watchdog drivers use 0xFFFF. Since you only went to 256 it made more sense to have it as 0xFF which is 255.
We can make it 65535 also.
>> +}
>> +
>> +static int bcm47xx_wdt_notify_sys(struct notifier_block *this,
>> + nsigned long code, void *unused)
> ^^^^
> Does this build ?
Nope. should be unsigned.
Kind regards,
Wim.
next prev parent reply other threads:[~2009-06-10 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 20:24 matthieu castet
2009-06-05 13:58 ` Florian Fainelli
2009-06-05 14:58 ` castet.matthieu
2009-06-06 10:58 ` Florian Fainelli
2009-06-05 16:57 ` add bcm47xx watchdog driver v2 matthieu castet
2009-06-05 19:48 ` add bcm47xx watchdog driver Andrew Morton
2009-06-05 20:30 ` matthieu castet
2009-06-08 14:15 ` Florian Fainelli
2009-06-10 17:17 ` Wim Van Sebroeck
2009-06-10 18:47 ` matthieu castet
2009-06-10 19:06 ` Wim Van Sebroeck [this message]
2009-06-05 19:50 ` Andrew Morton
2009-06-05 20:03 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610190602.GL16090@infomag.iguana.be \
--to=wim@iguana.be \
--cc=akpm@linux-foundation.org \
--cc=biblbroks@sezampro.rs \
--cc=castet.matthieu@free.fr \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®