mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong Wang <yong.y.wang@linux.intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH -tip] perf_counter/x86: Correct some event and umask values for Intel processors
Date: Fri, 12 Jun 2009 16:15:26 +0800	[thread overview]
Message-ID: <20090612081526.GB2286@ywang-moblin2.bj.intel.com> (raw)
In-Reply-To: <20090610104242.GB27724@elte.hu>

On Wed, Jun 10, 2009 at 12:42:42PM +0200, Ingo Molnar wrote:
> 
> * Yong Wang <yong.y.wang@linux.intel.com> wrote:
> 
> > On Tue, Jun 09, 2009 at 04:16:21PM +0200, Ingo Molnar wrote:
> > > 
> > > * Yong Wang <yong.y.wang@linux.intel.com> wrote:
> > > 
> > > > Correct some event and UMASK values according to Intel SDM.
> > > 
> > > Very nice, thanks!
> > > 
> > > were you able to test the Atom ones by any chance?
> > > 
> > 
> > You bet I was as I'm working on Moblin ;-) [...]
> 
> Heh :-)
> 
> > [...] However, some work while some do not. I'll take a look at 
> > the problematic ones. With the previous event and umask values, 
> > the pmc does not count at all for some events, like l1d-write-ops.
> 
> Interesting. I had a good look at the Atom details in the docs but 
> couldnt find anything suspicious. There's various umask level 
> extensions (sometimes cflags level ones) like whether to measure the 
> core or the thread, but the defaults (zero) seem to have OK 
> semantics for most of the events.
> 
> Btw., when mapping out event tables there's one little trick i used 
> to 'scan' an event, using 'perf stat' and raw event numbers:
> 
>   for ((i=0;i<256;i++)); do                                    \
>     perf stat -e $(printf "r%02x%02x\n" $i 0xc0) true 2>&1 |   \
>       grep -w raw | grep -vw 0;                                \
>   done
> 
> This scans all 256 umask values for the main event code of 0xc0, and 
> displays the umask values where the counter show some activity.
> 
> ( if it's some rare event then you might want to run something else 
>   that excercises that event, not /bin/true. )
> 

Just took a look at the problematics ones and found that the fixed
function PMCs do not work on current Atom processors. I tested on 3 Atom
netbooks and the results are the same. Just sent a quirk patch for that.

-Yong

  parent reply	other threads:[~2009-06-12  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 13:15 Yong Wang
2009-06-09 14:16 ` Ingo Molnar
2009-06-10  5:36   ` Yong Wang
2009-06-10 10:42     ` Ingo Molnar
2009-06-11  8:27       ` Yong Wang
2009-06-11 11:26         ` Ingo Molnar
2009-06-12  8:15       ` Yong Wang [this message]
2009-06-09 14:52 ` [tip:perfcounters/core] perf_counter, x86: " tip-bot for Yong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090612081526.GB2286@ywang-moblin2.bj.intel.com \
    --to=yong.y.wang@linux.intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®