mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: apw@shadowen.org, w.sang@pengutronix.de
Subject: checkpatch: false positives for __.*const
Date: Fri, 12 Jun 2009 13:00:39 +0200	[thread overview]
Message-ID: <20090612110039.GA5650@pengutronix.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

Hi,

init.h defines some attributes starting with '__' and ending with const, like
'__devinitconst'. They produce false positives with checkpatch:

ERROR: "fooconst bar" should be "foo const bar"
#154: FILE: drivers/uio/uio_of_genirq.c:70:
+static const struct of_device_id __devinitconst uio_of_genirq_match[] = {

like caused by this patch:

http://patchwork.kernel.org/patch/29664/

I investigated a bit but I am not sure if this should be fixed in the regexp
responsible for this error or, more general, in $Attributes.

Regards

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

                 reply	other threads:[~2009-06-12 11:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090612110039.GA5650@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®