From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: James Bottomley <JBottomley@Novell.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUG in pty_chars_in_buffer with 2.6.30 git head using ssh
Date: Sat, 13 Jun 2009 21:53:33 +0100 [thread overview]
Message-ID: <20090613215333.0e8a440e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1244909374.5323.23.camel@mulgrave.site>
On Sat, 13 Jun 2009 11:09:34 -0500
James Bottomley <JBottomley@Novell.com> wrote:
> This is a really odd one. I've used ssh into this box with this same
> kernel several times before, I got this (actually logged out as me over
> ssh then logged back in as root):
Its an ancient long standing bug but from the trace its inadvertently
become a NULL pointer deref rather than calling functions unsafely.
Change the if (!to ...) to if (!to || !to->ldisc || ...
and you'll get a race window thats rather like the one before.
The underlying problem is that the tty layer calls one tty ldisc from
under the locks of another but without holding the locks it needs. It
can't take both locks without deadlocking.
It's one I'm currently working on fixing.
prev parent reply other threads:[~2009-06-13 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 16:09 James Bottomley
2009-06-13 20:12 ` Eric W. Biederman
2009-06-13 20:53 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613215333.0e8a440e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=JBottomley@Novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®