mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>,
	Christian Kujau <lists@nerdbynature.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scripts/setlocalversion on readonly source
Date: Sun, 14 Jun 2009 22:27:04 +0200	[thread overview]
Message-ID: <20090614202704.GA3050@uranus.ravnborg.org> (raw)
In-Reply-To: <20090612075952.GA22436@ikn.schottelius.org>

> 
> 
> Do not update index on read only media.
> Idea published by Christian Kujau <lists@nerdbynature.de>.
> 
> diff --git a/scripts/setlocalversion b/scripts/setlocalversion
> index 0079047..46989b8 100755
> --- a/scripts/setlocalversion
> +++ b/scripts/setlocalversion
> @@ -39,8 +39,10 @@ if head=`git rev-parse --verify --short HEAD 2>/dev/null`; then
>  	        printf -- '-svn%s' "`git svn find-rev $head`"
>  	fi
>  
> -	# Are there uncommitted changes?
> -	git update-index --refresh --unmerged > /dev/null
> +	# Update index only on r/w media
> +	[ -w . ] && git update-index --refresh --unmerged > /dev/null
> +
> +	# Check for uncommitted changes
>  	if git diff-index --name-only HEAD | grep -v "^scripts/package" \
>  	    | read dummy; then
>  		printf '%s' -dirty

Please sign-off future patches.
I applied this with no signoff - but this is an exception.

	Sam

  parent reply	other threads:[~2009-06-14 20:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090611153332.d168e58e.akpm@linux-foundation.org>
     [not found] ` <20090612043922.GA13001@uranus.ravnborg.org>
2009-06-09 20:30   ` Christian Kujau
2009-06-12  7:59     ` Nico Schottelius
2009-06-12 17:03       ` Christian Kujau
2009-06-14 20:27       ` Sam Ravnborg [this message]
2009-06-14 20:46         ` Christian Kujau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090614202704.GA3050@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@nerdbynature.de \
    --cc=nico-linuxsetlocalversion@schottelius.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®