From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Hans J. Koch" <hjk@linutronix.de>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
devicetree-discuss@ozlabs.org,
Magnus Damm <magnus.damm@gmail.com>,
"Hans J. Koch" <hjk@linutronix.de>, Greg KH <gregkh@suse.de>
Subject: Re: [PATCH 2/2] uio: add an of_genirq driver
Date: Mon, 15 Jun 2009 00:12:07 +0100 [thread overview]
Message-ID: <20090615001207.1829e7b5@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090614122136.GD3639@local>
> > + if (!uioinfo->irq)
> > + uioinfo->irq = UIO_IRQ_NONE;
>
> Please don't do this. It's inconsistent if all other UIO drivers require
> people to use UIO_IRQ_NONE and you also allow zero. UIO_IRQ_NONE was
> introduced because 0 may be a legal interrupt number on some platforms.
Zero is not a valid IRQ number in the kernel (except in arch specific
depths). IRQ numbers are also *unsigned* so -1 isn't a safe definition.
Zero means no IRQ. If any old UIO code is assuming otherwise it wants
fixing.
It is the job of the platform to map a physical IRQ 0 to some other
representation if it exists outside of arch specific code. This was
decided some years ago and a large part of the kernel simply doesn't
support any notion of a real IRQ 0.
Alan
next prev parent reply other threads:[~2009-06-14 23:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 0:04 [PATCH 0/2] add OF wrapper for uio-pdrv-genirq Wolfram Sang
2009-06-12 0:04 ` [PATCH 1/2] uio/pdrv_genirq: Refactor probe routine to expose a generic part Wolfram Sang
2009-06-14 12:15 ` Hans J. Koch
2009-06-12 0:04 ` [PATCH 2/2] uio: add an of_genirq driver Wolfram Sang
2009-06-14 12:21 ` Hans J. Koch
2009-06-14 17:14 ` Wolfram Sang
2009-06-14 18:33 ` Hans J. Koch
2009-06-14 19:05 ` Wolfram Sang
2009-06-14 19:23 ` Hans J. Koch
2009-06-14 19:36 ` Wolfgang Grandegger
2009-06-14 20:34 ` Hans J. Koch
2009-06-14 22:00 ` Wolfram Sang
2009-06-14 23:01 ` Hans J. Koch
2009-06-14 23:46 ` Wolfram Sang
2009-06-14 23:50 ` Hans J. Koch
2009-06-14 19:27 ` Greg KH
2009-06-14 21:46 ` Wolfram Sang
2009-06-14 23:12 ` Alan Cox [this message]
2009-06-14 23:45 ` Hans J. Koch
2009-06-15 8:44 ` Alan Cox
2009-06-15 9:45 ` Benjamin Herrenschmidt
2009-06-14 14:40 ` Grant Likely
2009-06-16 9:04 ` Wolfram Sang
2009-06-16 12:46 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615001207.1829e7b5@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=devicetree-discuss@ozlabs.org \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=magnus.damm@gmail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®