From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty_ldisc: propagate errors from tty_ldisc_release
Date: Mon, 15 Jun 2009 16:51:26 +0100 [thread overview]
Message-ID: <20090615165126.1ecdff09@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090615153925.GA27696@damson.getinternet.no>
> Subject: [PATCH] tty_ldisc: propagate errors from tty_ldisc_release
>
> This is probably better than just ignoring the errors.
tty_ldisc_halt doesn't return an error as such - it just reports whether
the work could be cancelled. Nor can we exit on error paths in those
situations.
Basically one or two cases need to know if we cancelled the work queue or
not (so they can restart it).
So NAK the patch
prev parent reply other threads:[~2009-06-15 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 15:39 Vegard Nossum
2009-06-15 15:51 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615165126.1ecdff09@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®