From: Pavel Machek <pavel@ucw.cz>
To: Brian Swetland <swetland@google.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] [ARM] msm: make debugging UART (for DEBUG_LL) configurable
Date: Mon, 15 Jun 2009 20:34:33 +0200 [thread overview]
Message-ID: <20090615183433.GB10490@elf.ucw.cz> (raw)
In-Reply-To: <a55d774e0906151130x3892346fx5aa1f62c387b2090@mail.gmail.com>
On Mon 2009-06-15 11:30:11, Brian Swetland wrote:
> On Mon, Jun 15, 2009 at 6:20 AM, Pavel Machek<pavel@ucw.cz> wrote:
> > Hi!
> >
> >> Signed-off-by: Brian Swetland <swetland@google.com>
> >> ---
> >> arch/arm/mach-msm/Kconfig | 24 ++++++++++++++++++++++++
> >> arch/arm/mach-msm/include/mach/debug-macro.S | 25 ++++++++++++++++++-------
> >> arch/arm/mach-msm/include/mach/msm_iomap.h | 12 ++++++++++++
> >> arch/arm/mach-msm/include/mach/uncompress.h | 7 +++++++
> >> arch/arm/mach-msm/io.c | 3 +++
> >> 5 files changed, 64 insertions(+), 7 deletions(-)
> >
> > I'm not sure if this is appropriate for mainline at this point. It
> > seems like few people have debug cable at this point...
> >
> >> +config MSM_DEBUG_UART
> >> + int
> >> + default 1 if MSM_DEBUG_UART1
> >> + default 2 if MSM_DEBUG_UART2
> >> + default 3 if MSM_DEBUG_UART3
> >
> > ...and those that do, have it at fixed uart, no?
>
> Well, I'd like to support the SoC generally, not just Dream -- it's
> used in a bunch of different devices, and there's nothing that forces
> you to use UART3 everywhere (I certainly have seen some 7k hardware
> that uses UART1 as the debug serial port).
Aha, ok, I guess that should go to the changelog. (Nice bonus would be
if it was automatically/correctly set up when user selects machine
type... Actually, how does that work if you support few boards with
same kernel...?)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-06-15 18:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 2:39 Patches to get serial working on msm7k / htc dream Brian Swetland
2009-06-15 2:39 ` [PATCH 1/3] [ARM] msm_serial: serial driver for MSM7K onboard serial peripheral Brian Swetland
2009-06-15 2:39 ` [PATCH 2/3] [ARM] msm: make debugging UART (for DEBUG_LL) configurable Brian Swetland
2009-06-15 2:39 ` [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream device Brian Swetland
2009-06-15 6:42 ` Stefan Schmidt
2009-06-15 6:51 ` Brian Swetland
2009-06-15 7:15 ` Stefan Schmidt
2009-06-15 13:22 ` Pavel Machek
2009-06-15 18:25 ` Brian Swetland
2009-06-15 18:28 ` Pavel Machek
2009-06-15 18:51 ` Brian Swetland
2009-06-24 20:56 ` Pavel Machek
2009-06-25 13:55 ` Russell King - ARM Linux
2009-06-25 14:33 ` Alan Cox
2009-06-25 19:31 ` Brian Swetland
2009-06-25 20:46 ` Russell King - ARM Linux
2009-06-15 13:20 ` [PATCH 2/3] [ARM] msm: make debugging UART (for DEBUG_LL) configurable Pavel Machek
2009-06-15 18:30 ` Brian Swetland
2009-06-15 18:34 ` Pavel Machek [this message]
2009-06-15 18:43 ` Brian Swetland
2009-06-15 18:50 ` Pavel Machek
2009-06-15 3:18 ` [PATCH 1/3] [ARM] msm_serial: serial driver for MSM7K onboard serial peripheral Ryan Mallon
2009-06-15 8:54 ` Alan Cox
2009-06-15 8:52 ` Pavel Machek
2009-06-15 8:58 ` Russell King - ARM Linux
2009-06-15 9:55 ` Brian Swetland
2009-06-16 7:35 ` Russell King - ARM Linux
2009-06-15 8:52 ` Alan Cox
2009-06-17 3:07 ` Brian Swetland
2009-06-15 9:05 ` Linus Walleij
2009-06-17 12:17 ` Robert Love
2009-06-15 8:40 ` Patches to get serial working on msm7k / htc dream Pavel Machek
2009-06-18 0:31 Revised patch series for minimal HTC Dream support Brian Swetland
2009-06-18 0:31 ` [PATCH 1/3] [ARM] msm_serial: serial driver for MSM7K onboard serial peripheral Brian Swetland
2009-06-18 0:31 ` [PATCH 2/3] [ARM] msm: make debugging UART (for DEBUG_LL) configurable Brian Swetland
2009-06-18 10:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615183433.GB10490@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®