From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>,
Vegard Nossum <vegard.nossum@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [bug] WARNING: at drivers/char/tty_io.c:1266 tty_open+0x1ea/0x388()
Date: Tue, 16 Jun 2009 10:00:52 +0100 [thread overview]
Message-ID: <20090616100052.038f9d24@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090616084952.GA18263@elte.hu>
> I'm wondering, how long have these patches been in linux-next? Has
> no-one reported an easy (or easier) reproducer than a plain bootup
> (which really doesnt hit the tty code intentionally hard)?
Quite a while - and the open side stuff hasn't changed in the post 2.6.30
patches at all. Your box seems to show stuff up that most users just
don't hit.
> You should probably also write testcases and stress-tests if you
> modify code in this area.
I did - they hang the tty layers in 2.6.30 and earlier in about 60
seconds, it then corrupts the module counts and dies shortly after. I've
not published them because they can obviously be seriously misused.
I don't have the luxury of building on solid foundations trying to sort
the tty layer out - its been broken since 2.1.x when the lock_kernel
logic stopped applying to IRQ handlers.
Alan
next prev parent reply other threads:[~2009-06-16 9:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 8:10 tty_ldisc_try_get(): BUG kmalloc-8: Poison overwritten Ingo Molnar
2009-06-14 8:20 ` Pekka Enberg
2009-06-14 8:30 ` Pekka Enberg
2009-06-14 8:32 ` Pekka Enberg
2009-06-14 23:03 ` Vegard Nossum
2009-06-15 4:25 ` Pekka Enberg
2009-06-14 8:32 ` Ingo Molnar
2009-06-14 8:35 ` Ingo Molnar
2009-06-14 12:32 ` Ingo Molnar
2009-06-14 10:54 ` Alan Cox
2009-06-15 9:10 ` Catalin Marinas
2009-06-16 7:10 ` [bug] WARNING: at drivers/char/tty_io.c:1266 tty_open+0x1ea/0x388() Ingo Molnar
2009-06-16 8:44 ` Alan Cox
2009-06-16 8:49 ` Ingo Molnar
2009-06-16 9:00 ` Alan Cox [this message]
2009-06-16 19:43 ` Ingo Molnar
2009-06-16 10:13 ` Alan Cox
2009-06-16 10:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616100052.038f9d24@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®