From: Jesse Barnes <jesse.barnes@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andreas Mohr <andim2@users.sourceforge.net>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] PCI PM: Fix handling of devices without PM support by pci_target_state()
Date: Tue, 16 Jun 2009 12:18:28 -0700 [thread overview]
Message-ID: <20090616121828.2a7a8677@jbarnes-g45> (raw)
In-Reply-To: <200906142125.03418.rjw@sisk.pl>
On Sun, 14 Jun 2009 21:25:02 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> If a PCI device is not power-manageable either by the platform, or
> with the help of the native PCI PM interface, pci_target_state() will
> return either PCI_D3hot, or PCI_POWER_ERROR for it, depending on
> whether or not the device is configured to wake up the system. Alas,
> none of these return values is correct, because each of them causes
> pci_prepare_to_sleep() to return error code, although it should
> complete successfully in such a case.
>
> Fix this problem by making pci_target_state() always return PCI_D0
> for devices that cannot be power managed.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> Hi Jesse,
>
> I think this is 2.6.31 material, probably -stable too.
Applied to my linux-next branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-06-16 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 19:25 Rafael J. Wysocki
2009-06-16 19:18 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616121828.2a7a8677@jbarnes-g45 \
--to=jesse.barnes@intel.com \
--cc=andim2@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®