mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Theodore Tso <tytso@MIT.EDU>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: linux-next: ext4 tree build failure
Date: Tue, 16 Jun 2009 14:44:13 +1000	[thread overview]
Message-ID: <20090616144413.50e975f9.sfr@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2222 bytes --]

Hi Ted,

Today's linux-next build (powerpc ppc64_defconfig) failed like this after
the slab tree was merged:

In file included from fs/jbd2/checkpoint.c:26:
include/trace/events/jbd2.h:11: error: expected ')' before '(' token
include/trace/events/jbd2.h:31: error: expected ')' before '(' token
include/trace/events/jbd2.h:54: error: expected ')' before '(' token
include/trace/events/jbd2.h:77: error: expected ')' before '(' token
include/trace/events/jbd2.h:100: error: expected ')' before '(' token
include/trace/events/jbd2.h:122: error: expected ')' before '(' token
include/trace/events/jbd2.h:146: error: expected ')' before '(' token
fs/jbd2/checkpoint.c: In function 'jbd2_log_do_checkpoint':
fs/jbd2/checkpoint.c:361: error: implicit declaration of function 'trace_jbd2_checkpoint'

It looks like TRACE_EVENT is not defined.

The config differences are:
CONFIG_SLUB_DEBUG and CONFIG_SLUB change from y to n
CONFIG_SLQB_ALLOCATOR, CONFIG_SLQB and CONFIG_SLQB_DEBUG become y

The .i files looks very different (the bad one has TRACE_EVENT explictly
in there, while the other has it expanded).  It appears that some of the
tracing include files that should have been included explicitly were
being included implicitly by the slub include files.

So I have reverted commit 75ef2ffeb02c7e1fbe8114f2fddd2e8880397892
("jbd2: convert instrumentation from markers to tracepoints") for today.

This produced another error:

In file included from include/trace/ftrace.h:262,
                 from include/trace/define_trace.h:57,
                 from include/trace/events/ext4.h:720,
                 from fs/ext4/super.c:51:
include/trace/events/ext4.h: In function 'ftrace_raw_output_ext4_free_inode':
include/trace/events/ext4.h:12: error: implicit declaration of function 'jbd2_dev_to_name'

So I also reverted commit a6e130e94db16b324fbf2eeed2b310273625acf7 ("ext4: convert instrumentation from markers to tracepoints") after reverting the dependent commit 3f9c083c0ffd344da212c9813c3c5ddba1a65936 ("ext4: Fix 64-bit block type problem on 32-bit platforms") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2009-06-16  4:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  4:44 Stephen Rothwell [this message]
2009-06-16 20:30 ` Theodore Tso
2009-06-16 22:11   ` Theodore Tso
2009-06-17  5:46     ` Stephen Rothwell
2009-06-17  4:16   ` Pekka Enberg
2009-12-10  0:38 Stephen Rothwell
2009-12-10  2:10 ` tytso
2009-12-10  2:33   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090616144413.50e975f9.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=tytso@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®