From: Ingo Molnar <mingo@elte.hu>
To: Jason Baron <jbaron@redhat.com>
Cc: linux-kernel@vger.kernel.org, fweisbec@gmail.com,
laijs@cn.fujitsu.com, rostedt@goodmis.org, peterz@infradead.org,
mathieu.desnoyers@polymtl.ca, jiayingz@google.com,
bligh@google.com, roland@redhat.com, fche@redhat.com
Subject: Re: [PATCH 0/7] add syscall tracepoints
Date: Tue, 16 Jun 2009 21:32:20 +0200 [thread overview]
Message-ID: <20090616193220.GB12699@elte.hu> (raw)
In-Reply-To: <cover.1244837725.git.jbaron@redhat.com>
* Jason Baron <jbaron@redhat.com> wrote:
> hi,
>
> The following is an implementation of Frederic's syscall tracer on
> top of tracepoints. It adds the ability to toggle the entry/exit
> of each syscall via the standard
> events/syscalls/syscall_blah/enable interface. The implementation
> is done by adding 2 tracepoints. One on entry and one for exit.
>
> This implementation required a few 'core' api changes. I've added
> 'DECLARE_TRACE_REG()' macro which takes a register and and an
> unregister function as arguments. This allowed me to toggle the
> ftrace tif flag when the first tracepoint callback is added and
> the last is removed. Current callers of 'DECLARE_TRACE()' are not
> impacted.
>
> Another change was to call arch_init_ftrace_syscalls via an
> 'arch_initall'. In this implmentation I needed to access the
> syscalls_metadata structure at runtime in order to determine which
> syscalls were 'traceable'. Although the implementation uses
> SYSCALL_DEFINE() to set up the the trace events, for some reason
> at runtime there is no syscalls_metadata, associated with some of
> the SYSCALL_DEFINE() calls. I'm not quite sure why that is.
> However, by calling arch_init_ftrace_syscalls() at boot I can make
> sure the lists are in sync.
>
> thanks,
>
> -Jason
>
>
> arch/x86/include/asm/ftrace.h | 4 +-
> arch/x86/kernel/ftrace.c | 24 +++++-
> arch/x86/kernel/ptrace.c | 6 +-
> include/linux/syscalls.h | 63 +++++++++++++++
> include/linux/tracepoint.h | 27 ++++++-
> include/trace/syscall.h | 37 +++++++---
> kernel/trace/trace_events.c | 29 +++++---
> kernel/trace/trace_syscalls.c | 172 +++++++++++++++++++----------------------
> kernel/tracepoint.c | 38 +++++++++
> 9 files changed, 278 insertions(+), 122 deletions(-)
This looks far nicer structurally. Steve, Frederic, what's your take
on this series?
Ingo
next prev parent reply other threads:[~2009-06-16 19:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 21:24 Jason Baron
2009-06-12 21:24 ` [PATCH 1/7] " Jason Baron
2009-06-19 8:22 ` Li Zefan
2009-06-12 21:24 ` [PATCH 2/7] " Jason Baron
2009-06-19 3:24 ` Steven Rostedt
2009-06-19 8:26 ` Li Zefan
2009-06-12 21:24 ` [PATCH 3/7] " Jason Baron
2009-06-12 21:57 ` Mathieu Desnoyers
2009-06-15 14:12 ` Jason Baron
2009-06-15 15:24 ` Mathieu Desnoyers
2009-06-15 15:37 ` Frederic Weisbecker
2009-06-15 15:47 ` Mathieu Desnoyers
2009-06-19 1:59 ` Frederic Weisbecker
2009-06-19 3:29 ` Steven Rostedt
2009-06-19 3:40 ` Frederic Weisbecker
2009-06-12 21:24 ` [PATCH 4/7] " Jason Baron
2009-06-19 2:12 ` Frederic Weisbecker
2009-06-19 12:35 ` Mathieu Desnoyers
2009-06-19 14:56 ` Frederic Weisbecker
2009-06-19 8:31 ` Li Zefan
2009-06-12 21:24 ` [PATCH 5/7] " Jason Baron
2009-06-19 2:14 ` Frederic Weisbecker
2009-06-19 3:14 ` Li Zefan
2009-06-19 3:32 ` Steven Rostedt
2009-06-19 3:33 ` Frederic Weisbecker
2009-06-12 21:25 ` [PATCH 6/7] " Jason Baron
2009-06-19 2:28 ` Frederic Weisbecker
2009-06-19 21:49 ` Jason Baron
2009-06-12 21:25 ` [PATCH 7/7] " Jason Baron
2009-06-16 19:32 ` Ingo Molnar [this message]
2009-06-18 2:21 ` [PATCH 0/7] " Frederic Weisbecker
2009-06-19 3:07 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616193220.GB12699@elte.hu \
--to=mingo@elte.hu \
--cc=bligh@google.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®