From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Leo (Hao) Chen" <leochen@broadcom.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm@lists.arm.linux.org.uk"
<linux-arm@lists.arm.linux.org.uk>,
"Leo (Hao) Chen" <leochen@broadcom.com>
Subject: Re: QUESTION: new arch/arm/mach-bcmring code submission
Date: Wed, 17 Jun 2009 10:20:11 +0100 [thread overview]
Message-ID: <20090617102011.41a3ecfa@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <8628FE4E7912BF47A96AE7DD7BAC0AADCB2592D730@SJEXCHCCR02.corp.ad.broadcom.com>
> 1. We have a whole lot of OS-less csp (chip support package) code that is used in our drivers and arch code. We will release them as GPL but we want to keep and maintain them in our own csp directories. Can we put them under arch/arm/mach-bcmring/csp and arch/arm/mach-bcmring/include/csp directories? If not, what's the proper way to do that?
Difficult to tell without seeing it.
> 2. We have driver header files which are currently kept in the include/linux/broadcom directory. Where is the proper place to put our driver header files in Linux kernel? Any guidelines?
Headers generally go in locations according to what they are for.
Thus
arch/arm/plat-[name]/include/plat
arch/arm/mach-[name]/include/mach
Stuff that defines public (user space) interfaces and structures tends to
be in include/linux while there are directories such as include/net/
include/usb/ - split by function rather than platform
> 3. Do I need to submit our code to any maintainer or just submit to LKML
Core changes that affect the internals of things like arch/arm and
include/asm-arm need to go via the maintainer (see MAINTAINERS): In this
case Russell King - and see: http://www.arm.linux.org.uk
After that platform changes can begin to go in, and then drivers. If you
are new to this then initially going through another maintainer will help
with quality and correctness, but after a time a lot of stuff would go
directly (stuff that affected only bcmring drivers/code). That also is a
good reason to keep as much of the code separated cleanly from the core
code as possible.
next prev parent reply other threads:[~2009-06-17 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 19:44 Leo (Hao) Chen
2009-06-17 9:20 ` Alan Cox [this message]
2009-06-17 11:31 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617102011.41a3ecfa@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=leochen@broadcom.com \
--cc=linux-arm@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®