From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Rob Emanuele <rob@emanuele.us>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] atmel-mci: Unified Atmel MCI drivers (AVR32 & AT91)
Date: Wed, 17 Jun 2009 12:08:49 +0200 [thread overview]
Message-ID: <20090617120849.4b11386a@hskinnemoen-d830> (raw)
In-Reply-To: <4A38BDB8.5030804@atmel.com>
Nicolas Ferre wrote:
> > -#define ATMCI_DATA_ERROR_FLAGS (MCI_DCRCE | MCI_DTOE | MCI_OVRE | MCI_UNRE)
> > +#define ATMCI_DATA_ERROR_FLAGS (MCI_RINDE | MCI_RDIRE | MCI_RCRCE \
> > + | MCI_RENDE | MCI_RTOE | MCI_DCRCE \
> > + | MCI_DTOE | MCI_OVRE | MCI_UNRE)
>
> Haavard, is it ok to add those flags on an AVR32 platform for now ?
It probably doesn't hurt on AVR32. But I'm not a great fan since it
seems like the wrong thing to do, and it may simply mask the real
problem.
Haavard
next prev parent reply other threads:[~2009-06-17 10:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 0:54 Rob Emanuele
2009-06-17 0:54 ` [PATCH 2/6] atmel-mci: Platform configuration to the the atmel-mci driver Rob Emanuele
2009-06-17 10:27 ` Nicolas Ferre
2009-06-18 19:58 ` Andrew Victor
2009-06-18 20:00 ` Andrew Victor
2009-06-17 0:54 ` [PATCH 3/6] atmel-mci: Optional controller reset before every command Rob Emanuele
2009-06-17 8:32 ` Marc Pignat
2009-06-17 18:27 ` Robert Emanuele
2009-06-17 0:54 ` [PATCH 4/6] atmel-mci: CLKDIV cap to restrict the MCI controller speed Rob Emanuele
2009-06-17 0:54 ` [PATCH 5/6] atmel-mci: Power control option for each MMC Slot Rob Emanuele
2009-06-17 8:08 ` Marc Pignat
2009-06-17 0:54 ` [PATCH 6/6] atmel-mci: Platform driver MMC slot power control Rob Emanuele
2009-06-17 1:23 ` Ryan Mallon
2009-06-17 9:56 ` [PATCH 1/6] atmel-mci: Unified Atmel MCI drivers (AVR32 & AT91) Nicolas Ferre
2009-06-17 10:08 ` Haavard Skinnemoen [this message]
2009-06-23 16:28 ` Nicolas Ferre
[not found] ` <95818a17c2b96d3769f4e1d3de26208647111758.1245778411.git.nicolas.ferre@atmel.com>
2009-06-23 17:39 ` [PATCH 1/2] " Nicolas Ferre
2009-09-02 7:31 ` Haavard Skinnemoen
[not found] ` <f8889fb59887a970581697beb313363a6a065606.1245778411.git.nicolas.ferre@atmel.com>
2009-06-23 17:39 ` [PATCH 2/2] AT91: atmel-mci: Platform configuration to the the atmel-mci driver Nicolas Ferre
2009-06-23 21:36 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-26 19:26 ` Robert Emanuele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617120849.4b11386a@hskinnemoen-d830 \
--to=haavard.skinnemoen@atmel.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rob@emanuele.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®