Re: [PATCH]x86-tsc.c : fix compile warning

[Balbir Singh <balbir@linux.vnet.ibm.com>]

* Ingo Molnar <mingo@elte.hu> [2009-06-17 18:23:03]:

> 
> * Frans Pop <elendil@planet.nl> wrote:
> 
> > On Wednesday 17 June 2009, Ingo Molnar wrote:
> > > Ah, and you fixed in what a superior way: you improved the code in
> > > the process :-) This is how warnings should be fixed really.
> > 
> > Hmm. Did you also see Pavel's reply to that patch [1]:
> > ! But that's a bug to be fixed, I'd say? ... actually I believe you are
> > ! introducing a bug here. Yes, old code would put random numbers in
> > ! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing
> > ! oops there.
> > 
> > Was his comment incorrect?
> > 
> > Cheers,
> > FJP
> > 
> > [1] http://lkml.org/lkml/2009/5/24/159
> 
> hm, Pavel seems right - i missed that. Subrata, mind sending an 
> updated patch?
>

Hi, Ingo,

Yes, it does seem that we'll oops at *lpj, but to be honest the code
is badly written, ideally the CONFIG_SMP part should be abstracted
out, having that in a if loop makes reading it time consuming and
kills a few neuro cells each time.
 

-- 
	Balbir