From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [PATCH 2/3] usb-serial: regression fix to move sysrq from hot path
Date: Thu, 18 Jun 2009 10:13:20 +0100 [thread overview]
Message-ID: <20090618101320.15c036a6@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1245291609-14871-3-git-send-email-jason.wessel@windriver.com>
> + if (port->console) {
unlikely(port->console) I think is justified
> + for (i = 0; i < urb->actual_length; i++, ch++) {
> + if (!usb_serial_handle_sysrq_char(port, *ch))
> + tty_insert_flip_char(tty, *ch, TTY_NORMAL);
But thats a minor twiddle so
Acked-by: Alan Cox <alan@linux.intel.com>
Alan
next prev parent reply other threads:[~2009-06-18 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 2:20 [PATCH 0/3] usb console regression fixes - 2.6.31 Jason Wessel
2009-06-18 2:20 ` [PATCH 1/3] usb,console: Fix regression in usb console on kernel boot Jason Wessel
2009-06-18 2:20 ` [PATCH 2/3] usb-serial: regression fix to move sysrq from hot path Jason Wessel
2009-06-18 2:20 ` [PATCH 3/3] usb-serial: optimize sysrq function calls Jason Wessel
2009-06-18 9:13 ` Alan Cox [this message]
2009-06-18 11:48 ` [PATCH 2/3] usb-serial: regression fix to move sysrq from hot path Jason Wessel
2009-06-18 9:11 ` [PATCH 1/3] usb,console: Fix regression in usb console on kernel boot Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090618101320.15c036a6@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®